You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I fixed this as part of my pull request
Newyerushalmi Code to implement New Yerushalmi Yomi #206
But incase you dont want to accept that request
Beawre that the current implimentation of YerushalmiYomiCalculator -> getDafYomiYerushalmi()
For Mesectas after the first will returen LastMisectah , LastMisectaMaxDaf+1
for the 1st daf of a new mesechta
The fix I did is on line 100 if (total <= BLATT_PER_MASSECTA[j]) {
replace <= with <
Anotherr fix would be to start the daf counter from not 0
but I did not try totest such a solution
The text was updated successfully, but these errors were encountered:
elazarrosenthal
changed the title
In getDafYomiYerushalmi() LastMischtas, L:astMesechtahMaxDaf + 1 returned for Mesctas after Brachos
In getDafYomiYerushalmi() LastMischtas, LastMesechtahMaxDaf + 1 returned for Mesctas after Brachos
Apr 28, 2023
elazarrosenthal
changed the title
In getDafYomiYerushalmi() LastMischtas, LastMesechtahMaxDaf + 1 returned for Mesctas after Brachos
In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Mesctas after Brachos
Apr 28, 2023
elazarrosenthal
changed the title
In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Mesctas after Brachos
In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Meschtas after Brachos
Apr 28, 2023
elazarrosenthal
changed the title
In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Meschtas after Brachos
In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Daf 1 of Meschtas after Brachos
Apr 28, 2023
I fixed this as part of my pull request
Newyerushalmi Code to implement New Yerushalmi Yomi
#206
But incase you dont want to accept that request
Beawre that the current implimentation of YerushalmiYomiCalculator -> getDafYomiYerushalmi()
For Mesectas after the first will returen LastMisectah , LastMisectaMaxDaf+1
for the 1st daf of a new mesechta
The fix I did is on line 100 if (total <= BLATT_PER_MASSECTA[j]) {
replace <= with <
Anotherr fix would be to start the daf counter from not 0
but I did not try totest such a solution
The text was updated successfully, but these errors were encountered: