Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Daf 1 of Meschtas after Brachos #207

Closed
elazarrosenthal opened this issue Apr 28, 2023 · 2 comments

Comments

@elazarrosenthal
Copy link

elazarrosenthal commented Apr 28, 2023

I fixed this as part of my pull request
Newyerushalmi Code to implement New Yerushalmi Yomi
#206
But incase you dont want to accept that request
Beawre that the current implimentation of YerushalmiYomiCalculator -> getDafYomiYerushalmi()
For Mesectas after the first will returen LastMisectah , LastMisectaMaxDaf+1
for the 1st daf of a new mesechta

The fix I did is on line 100 if (total <= BLATT_PER_MASSECTA[j]) {

replace <= with <

Anotherr fix would be to start the daf counter from not 0
but I did not try totest such a solution

@elazarrosenthal elazarrosenthal changed the title In getDafYomiYerushalmi() LastMischtas, L:astMesechtahMaxDaf + 1 returned for Mesctas after Brachos In getDafYomiYerushalmi() LastMischtas, LastMesechtahMaxDaf + 1 returned for Mesctas after Brachos Apr 28, 2023
@elazarrosenthal elazarrosenthal changed the title In getDafYomiYerushalmi() LastMischtas, LastMesechtahMaxDaf + 1 returned for Mesctas after Brachos In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Mesctas after Brachos Apr 28, 2023
@elazarrosenthal elazarrosenthal changed the title In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Mesctas after Brachos In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Meschtas after Brachos Apr 28, 2023
@elazarrosenthal elazarrosenthal changed the title In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Meschtas after Brachos In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Daf 1 of Meschtas after Brachos Apr 28, 2023
@KosherJava
Copy link
Owner

@elazarrosenthal ,
Please clarify
replace <= with -
Thanks

@KosherJava
Copy link
Owner

Thanks @elazarrosenthal . I realize now that - was =. This is now done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants