Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newyerushalmi Code to implement New Yerushalmi Yomi #206

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

elazarrosenthal
Copy link

See Readme in directory new-yerushalmi-dev-notes
contains notes and scripts that should probably be left out of master

Even if you dont want whole code My testing uncoverd 1 bug in existing
YerushalmiYomiCalculator -> public static Daf getDafYomiYerushalmi(JewishCalendar calendar) {
for (int j = 0; j < BLATT_PER_MASSECTA.length; j++) {
should be < not <= (messed up 1st page of new mesechta)

@elazarrosenthal
Copy link
Author

I was thinking about the <= bug

it might be clearer codeto init the daf number to 1 not 0
and not add 1 when creating the daf

didn't test this way just was bugging me why it was a problem

current way 1st daf is 0 and no such daf

@elazarrosenthal
Copy link
Author

screenshot

I got the results I want from the code

@elazarrosenthal
Copy link
Author

is kilahim supposed to have 2 yuds?

@KosherJava
Copy link
Owner

@elazarrosenthal ,
I am still on the fence on this one, but can you clean up the PR to remove the many non-relevant files in the PR? Limit it to the 5 Java files (two core and 3 test files).
Thanks

@elazarrosenthal
Copy link
Author

Junk removed

@elazarrosenthal
Copy link
Author

I am not sure if there are many people using the "NEW" yerushalmi dafyomi scedual or if its just an Artscroll thing
I do know there are online shiurim following this
and I started to do it myself so I wanted some way of adding the scedual to my code

For most of the tables I generated the code form sources descrbed in my dev direcotry on other branch (see below)

Even if you dont want the NEW code you might want to take my Cycle11 test for the original cycle as that is how I found some of the bugs I reported

The tables from the java were created from sources
I created a new branch to keep all the dev code and notes also

https://github.com/elazarrosenthal/zmanim/tree/newyerushalmi_dev
I am keeping this branch for the PR
and removed dev notes and scripts

since I deleted the file putting readme here
Contact: Elazar Rosenthal - [email protected] or [email protected]
This directory contains scripts and files
to help convert yerushalmi daf yomi tables to usable code

I am not sure what names to use for the new scedual
I have used NEW and in some places ORIG
hebcal.com apparently went with vilna and shottenstien
please pick better namming if you think appropreate (orig/vilnam new/shottenstien/artscroll/oxvihadar)

README.txt - this file
ArtScrollPdf - original attempt to extract data from Artscroll PDF
hebcal.com - more files from website of same name - not used at this time
DafYomiCoIlWebSite - cut and paste html tables from this site and pasted to spread sheet and saved as csv
Work went on from there

Note: at first I thought that there where just differences in page counts
however I discoved to other things

  1. The Original scedual skips Yom Kippur and TiSha-BaAv - the new one does not
  2. The order of the Mesactas in the scedual differs

I opened a spreadsheet and pasted the website csv and Artscroll pdf csv side by side on same spreadsheet
and confirmed that the mesechtos and pages and dates all lined up so using the website csv as source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants