Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digitize with class unsupported for Short, BigInteger, Byte #971

Open
Jolanrensen opened this issue Nov 26, 2024 · 0 comments
Open

Digitize with class unsupported for Short, BigInteger, Byte #971

Jolanrensen opened this issue Nov 26, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
0.16.0

Comments

@Jolanrensen
Copy link
Collaborator

Digitize (I'm not even 100% sure what it does) uses a strange separate convert function:

dataframe/core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/digitize.kt

Line 20 in 273c095

bins = bins.toList().map { org.jetbrains.kotlinx.dataframe.impl.convert(it, kclass) },

dataframe/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/Utils.kt

Line 67 in 273c095

internal fun <T : Any> convert(src: Int, tartypeOf: KClass<T>): T =

This should use the generic getConverter() function the library has in place.
@Jolanrensen Jolanrensen added the bug Something isn't working label Nov 26, 2024
@Jolanrensen Jolanrensen added this to the 0.16.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
1 participant
@Jolanrensen