Skip to content

Commit

Permalink
Fix dokka-core artifact name for runners
Browse files Browse the repository at this point in the history
  • Loading branch information
whyoleg committed Oct 19, 2023
1 parent 0beee0e commit 1f50760
Show file tree
Hide file tree
Showing 24 changed files with 32 additions and 26 deletions.
3 changes: 1 addition & 2 deletions dokka-runners/cli/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ plugins {
}

dependencies {
// TODO [structure-refactoring] the name of the artifact should be `dokka-core`. Add substitution
implementation("org.jetbrains.dokka:core")
implementation("org.jetbrains.dokka:dokka-core")
implementation(libs.kotlinx.cli)

testImplementation(kotlin("test"))
Expand Down
3 changes: 1 addition & 2 deletions dokka-runners/gradle-plugin-classic/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ plugins {
}

dependencies {
// TODO [structure-refactoring] the name of the artifact should be `dokka-core`. Add substitution
api("org.jetbrains.dokka:core")
api("org.jetbrains.dokka:dokka-core")

compileOnly(libs.gradlePlugin.kotlin)
compileOnly(libs.gradlePlugin.kotlin.klibCommonizerApi)
Expand Down
3 changes: 1 addition & 2 deletions dokka-runners/maven-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ plugins {
}

dependencies {
// TODO [structure-refactoring] the name of the artifact should be `dokka-core`. Add substitution
implementation("org.jetbrains.dokka:core")
implementation("org.jetbrains.dokka:dokka-core")

implementation(libs.apacheMaven.core)
implementation(libs.apacheMaven.pluginApi)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/analysis-java-psi/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

api(libs.intellij.java.psi.api)

Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/analysis-kotlin-api/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
}

registerDokkaArtifactPublication("analysisKotlinApi") {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.analysisKotlinApi)

api(libs.kotlin.compiler)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.analysisKotlinApi)

implementation(projects.analysisKotlinDescriptorsCompiler)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/analysis-kotlin-symbols/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.analysisKotlinApi)

implementation(projects.analysisMarkdownJb)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/analysis-markdown-jb/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(libs.jsoup)
implementation(libs.jetbrains.markdown)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/core-test-api/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
api(projects.core)
api(projects.dokkaCore)

implementation(kotlin("reflect"))
}
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-all-modules-page/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ registerDokkaArtifactPublication("dokkaAllModulesPage") {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.analysisKotlinApi)

implementation(projects.pluginBase)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(projects.pluginBase)

Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-base-test-utils/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.pluginBase)

api(projects.analysisKotlinApi)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-base/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.analysisKotlinApi)

implementation(projects.analysisMarkdownJb)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(projects.pluginBase)
implementation(projects.pluginGfm)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-gfm/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(projects.pluginBase)

Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-javadoc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.analysisKotlinApi)

implementation(projects.pluginBase)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(projects.pluginBase)
implementation(projects.pluginJekyll)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-jekyll/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(projects.pluginBase)
implementation(projects.pluginGfm)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-kotlin-as-java/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)
compileOnly(projects.analysisKotlinApi)

implementation(projects.pluginBase)
Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-mathjax/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ plugins {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(projects.pluginBase)

Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-templating/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ registerDokkaArtifactPublication("templating-plugin") {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

api(libs.jsoup)

Expand Down
2 changes: 1 addition & 1 deletion dokka-subprojects/plugin-versioning/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ registerDokkaArtifactPublication("versioning-plugin") {
}

dependencies {
compileOnly(projects.core)
compileOnly(projects.dokkaCore)

implementation(projects.pluginBase)
implementation(projects.pluginTemplating)
Expand Down
9 changes: 9 additions & 0 deletions dokka-subprojects/settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,12 @@ include(
":plugin-templating",
":plugin-versioning",
)

// TODO [structure-refactoring]
// this is required for included build support
// the name of the artifact published now is `dokka-core`, but module named `core`
// dependency substitution in this case doesn't work for some reason
// may be we fall here in one of the unsupported cases:
// https://docs.gradle.org/current/userguide/composite_builds.html#included_build_substitution_limitations
// may be we need to find some other solution for this
project(":core").name = "dokka-core"

0 comments on commit 1f50760

Please sign in to comment.