Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K2] KMP: Constructors in actual class are missing keyword actual #3378

Closed
atyrin opened this issue Nov 27, 2023 · 1 comment · Fixed by #3500
Closed

[K2] KMP: Constructors in actual class are missing keyword actual #3378

atyrin opened this issue Nov 27, 2023 · 1 comment · Fixed by #3500
Assignees
@vmishenev
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 upstream bug An issue that appears due to an upstream dependency bug, such as kotlin-compiler
Milestone
Dokka 2.0.0

Comments

@atyrin
Copy link
Contributor

atyrin commented Nov 27, 2023 

// commonMain
expect class A()

actual class A{
    actual constructor(){}
    constructor(s: String): this(){}
}

K2
image

K1
image

Installation

  • Dokka version: 1.9.20

Parent: #3328
@atyrin atyrin added bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels Nov 27, 2023
@atyrin atyrin changed the title [K2] Cobstructors in actual class are missing keyword actual [K2] Constructors in actual class are missing keyword actual Nov 27, 2023
@vmishenev vmishenev changed the title [K2] Constructors in actual class are missing keyword actual [K2] KMP: Constructors in actual class are missing keyword actual Dec 4, 2023
@IgnatBeresnev IgnatBeresnev mentioned this issue Dec 12, 2023
Open
12 tasks
@vmishenev vmishenev added the upstream bug An issue that appears due to an upstream dependency bug, such as kotlin-compiler label Dec 14, 2023
@vmishenev
Copy link
Contributor

vmishenev commented Dec 14, 2023 •
edited
Loading

It is blocked by https://youtrack.jetbrains.com/issue/KT-64345/Analysis-API-isActualfalse-for-actual-constructor-symbol

Updated
it was on Dokka's side.

@vmishenev vmishenev mentioned this issue Feb 18, 2024
Merged
@vmishenev vmishenev linked a pull request Feb 18, 2024 that will close this issue
[K2] Fix missing actual keyword for constructors #3500
Merged
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmishenev vmishenev

Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 upstream bug An issue that appears due to an upstream dependency bug, such as kotlin-compiler
Projects
None yet
Milestone
Dokka 2.0.0
Development

Successfully merging a pull request may close this issue.

[K2] Fix missing actual keyword for constructors Kotlin/dokka
3 participants
@atyrin @vmishenev @IgnatBeresnev