Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry fixup_payment_params method adds invalid PENC value #21

Open
manleyac opened this issue Jan 7, 2022 · 1 comment
Open

Inquiry fixup_payment_params method adds invalid PENC value #21

manleyac opened this issue Jan 7, 2022 · 1 comment

Comments

@manleyac
Copy link

manleyac commented Jan 7, 2022

When creating an inquiry, fixup_payment_params is called. It checks the PTYP and updates the PENC accordingly. If PTYP
is not one of the cases, then PENC is set to 'NONE' which is never an accepted value according to the docs here

This causes an error to be returned when trying to make a RIS call with a paypal payment.

Would it be possible to remove the else block from the case statement?

params[:PENC] ||= 'NONE'

@pelargir
Copy link

pelargir commented Oct 1, 2024

This line was removed by 3243d6a

I believe this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants