Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass EventFilterBase based on the amount of topics an event defines #84

Open
ArtificialPB opened this issue Feb 23, 2024 · 0 comments
Labels
difficulty: easy Easy issues to resolve, suitable for beginners. type: feature Feature requests.

Comments

@ArtificialPB
Copy link
Member

Module

ABI

📝 Description

We have only two subclasses: AnonymousEventFilter and EventFilter, both of which expose filtering methods for all 4 (max) number of topics that an event can define. For each EventFactory implementation, use the subclass which exposes the same number of topics as the event has defined.

Create a specific subclass for each number of topics an event can define:

  • EventFilter: from 1 to 3 topics, topicId occupies the topic0 slot so only 3 are available
  • AnonymousEventFilter: from 0 to 4 topics (no topicId).
@ArtificialPB ArtificialPB added type: feature Feature requests. difficulty: easy Easy issues to resolve, suitable for beginners. labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy Easy issues to resolve, suitable for beginners. type: feature Feature requests.
Projects
None yet
Development

No branches or pull requests

1 participant