Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Thumbnail Error handling #95

Open
vbanuelos opened this issue Oct 6, 2015 · 5 comments
Open

Image Thumbnail Error handling #95

vbanuelos opened this issue Oct 6, 2015 · 5 comments

Comments

@vbanuelos
Copy link
Contributor

Currently:
Thumbnail Images stop loading once there is bad image.

EX/
6 images. Image 3 returns error. Only images 1, 2 appear in thumbnails. Opening viewer shows 6 images in image count, and able to cycle through all images (including bad one).

Desired:
Remove bad image from thumbnails and viewer. Return nanoGallery error message with bad image url.

@vbanuelos vbanuelos changed the title Error handling Image Thumbnail Error handling Oct 6, 2015
@vbanuelos
Copy link
Contributor Author

I'm almost certain it currently fails at the thumbnailAppear function when called by the ResizeGalleryWidthtAuto function

The problem appears to come from the ResizeGalleryWidthtAuto function. Specifically within the both each loops. If an image never comes back, the loops always stop at that point.

@Kris-B
Copy link
Owner

Kris-B commented Oct 18, 2015

What do you mean with "bad image"?

@Kris-B
Copy link
Owner

Kris-B commented Oct 25, 2015

The ResizeGalleryWidthtAuto function requires the height and the width of the thumbnail images.

Could it be that a bad image has a width > 0 and a height = 0?

I don't know how to reproduce this issue...

@Kris-B
Copy link
Owner

Kris-B commented Oct 25, 2015

btw, where are hosting your images?

@vbanuelos
Copy link
Contributor Author

Sorry about the delay in answering. I meant bad images as in a link that now 404's.

We had an issue where an image was deleted, but was still being referenced by our implementation. All images would load in the thumbnail gallery up until that deleted image (in our case 3/8). The image viewer would work as expected (showing that it was a broken image).

Our content is being hosted by Azure Media Services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants