-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Thumbnail Error handling #95
Comments
The problem appears to come from the ResizeGalleryWidthtAuto function. Specifically within the both each loops. If an image never comes back, the loops always stop at that point. |
What do you mean with "bad image"? |
The ResizeGalleryWidthtAuto function requires the height and the width of the thumbnail images. Could it be that a bad image has a width > 0 and a height = 0? I don't know how to reproduce this issue... |
btw, where are hosting your images? |
Sorry about the delay in answering. I meant bad images as in a link that now 404's. We had an issue where an image was deleted, but was still being referenced by our implementation. All images would load in the thumbnail gallery up until that deleted image (in our case 3/8). The image viewer would work as expected (showing that it was a broken image). Our content is being hosted by Azure Media Services. |
Currently:
Thumbnail Images stop loading once there is bad image.
EX/
6 images. Image 3 returns error. Only images 1, 2 appear in thumbnails. Opening viewer shows 6 images in image count, and able to cycle through all images (including bad one).
Desired:
Remove bad image from thumbnails and viewer. Return nanoGallery error message with bad image url.
The text was updated successfully, but these errors were encountered: