Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Diagram hasCompany() should take in input #6

Open
KristopherPTaslim opened this issue Apr 16, 2022 · 1 comment
Open

Sequence Diagram hasCompany() should take in input #6

KristopherPTaslim opened this issue Apr 16, 2022 · 1 comment

Comments

@KristopherPTaslim
Copy link
Owner

KristopherPTaslim commented Apr 16, 2022

Screenshot 2022-04-16 at 3.37.44 PM.png

Screenshot 2022-04-16 at 3.38.06 PM.png

In the sequence diagram, hasCompany() should be hasCompany(xyz)

@nus-pe-script
Copy link

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Reason for changing to VeryLow:
Like the issue has stated, the DG has stated that check(xyz) will contain hasCompany(xyz).

In particular, the diagram shown is utilising minimal notation described in the textbook as it does not result in ambiguities (explained right above the diagram).

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: [replace this with your reason]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants