Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: register metrics only once and add hit-miss #206

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Krukov
Copy link
Owner

@Krukov Krukov commented Mar 4, 2024

Fix for #200

@Krukov Krukov force-pushed the fix-duplicated-ts branch from 86dc8d9 to 4a0ab1e Compare March 4, 2024 21:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.74%. Comparing base (f5179d2) to head (4a0ab1e).
Report is 2 commits behind head on master.

Files Patch % Lines
cashews/contrib/prometheus.py 73.33% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   93.76%   93.74%   -0.03%     
==========================================
  Files          54       54              
  Lines        3529     3533       +4     
  Branches      609      610       +1     
==========================================
+ Hits         3309     3312       +3     
+ Misses        148      147       -1     
- Partials       72       74       +2     
Flag Coverage Δ
unittests 93.65% <73.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krukov Krukov force-pushed the fix-duplicated-ts branch from 4a0ab1e to 495c763 Compare March 4, 2024 22:25
@Krukov Krukov force-pushed the fix-duplicated-ts branch from 495c763 to fb762c8 Compare March 4, 2024 22:30
@Krukov Krukov merged commit 02df6c0 into master Mar 4, 2024
7 of 8 checks passed
@Krukov Krukov deleted the fix-duplicated-ts branch May 5, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants