Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review CEL rules and allow defaults #297

Open
maksymvavilov opened this issue Nov 7, 2024 · 0 comments
Open

Review CEL rules and allow defaults #297

maksymvavilov opened this issue Nov 7, 2024 · 0 comments

Comments

@maksymvavilov
Copy link
Contributor

maksymvavilov commented Nov 7, 2024

What

We have a naive approach to CEL validation now (they were mostly copied from existing rules of hostnames/ports). We need to reevaluate each rule and ensure they are functioning. For example: the rule on the pointer value does not work.

How

Review each rule here and evaluate.
Known problems that were reported by QA
For most of them, we could set default values. For example default interval, protocol or port.
Add test cases for each rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant