Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help(er functions?) to make easier to work with HTTPQueryParamMatch in CEL #117

Open
alexsnaps opened this issue Oct 25, 2024 · 2 comments
Open

Help(er functions?) to make easier to work with HTTPQueryParamMatch in CEL #117

alexsnaps opened this issue Oct 25, 2024 · 2 comments
Assignees
@alexsnaps

Comments

@alexsnaps
Copy link
Member

We want to implement what is feasible with HTTPQueryParamMatch in Wasm... today you can "only" get to request.query... which is... leaving a whole lot on the CEL expression author to do on their own. Can we make this easier on them?
@alexsnaps alexsnaps mentioned this issue Oct 25, 2024
Merged
15 tasks
@alexsnaps alexsnaps changed the title Help(er functions?) to help working with HTTPQueryParamMatch in CEL Help(er functions?) to make easier to work with HTTPQueryParamMatch in CEL Oct 25, 2024
@alexsnaps
Copy link
Member Author

Maybe a good start is to expose a Map<String, String>, possibly thru request.query_params, or a helper function parseQueryParams(request.query) that'd split and url_decode the whole string? Would a Map suffice for implementing Predicates based of HTTPQueryParamMatch?

@eguzki eguzki self-assigned this Oct 29, 2024
@alexsnaps
Copy link
Member Author

Duh! Looks like we raced for that one... see #126

@eguzki eguzki assigned alexsnaps and unassigned eguzki Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsnaps alexsnaps

Labels
None yet
Projects
Kuadrant
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexsnaps @eguzki