Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New implementation of social links #70

Closed
dulldesk opened this issue Oct 26, 2020 · 2 comments · Fixed by #77
Closed

New implementation of social links #70

dulldesk opened this issue Oct 26, 2020 · 2 comments · Fixed by #77
Assignees
@dulldesk
Labels
backend low priority

Comments

@dulldesk
Copy link
Contributor

dulldesk commented Oct 26, 2020 •
edited
Loading

Just thinking over the difference in YouTube URLs and the resulting confusion (both for us and possible users), it seems like the better idea is to scrap these different types of social links and figure it out ourselves. Users should put in any URL, and when rendering we can do some regex matching to figure out what site, and icon, we should use.

Originally posted by @TheAvidDev in #68 (comment)
@dulldesk dulldesk mentioned this issue Oct 26, 2020
Open
@dulldesk dulldesk self-assigned this Nov 25, 2020
@dulldesk
Copy link
Contributor Author

dulldesk commented Nov 25, 2020 •
edited
Loading

Address this (regarding object_id) in the new code.

@dulldesk dulldesk assigned dulldesk and unassigned dulldesk Nov 25, 2020
@dulldesk dulldesk mentioned this issue Jan 4, 2021
Merged
@dulldesk
Copy link
Contributor Author

dulldesk commented Jan 4, 2021 •
edited
Loading

(Wrong issue, but it may be relevant to the object_id concerns. original comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dulldesk dulldesk

Labels
backend low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use regex matching to determine icons for SocialLinkAttachements dulldesk/stratus
1 participant
@dulldesk