-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Age Calculation Logic with Improved Date Handling #1425
Refactored Age Calculation Logic with Improved Date Handling #1425
Conversation
It is a complete different code than age.py
It's great having you contribute to this projectThank you for opening a Pull Request ๐ , Welcome to Project Guidance ๐ We will review everything and get back to you :) |
I changed to entire code, thus I uploaded a different file for the updates code namely "Updated age.py". Iโm new to GSSoC and GitHub, so please forgive me if I made any mistakes during this process. I appreciate any feedback you may have, and let me know if any changes are required. Kindly assign the level too. Thank You! |
@KashishJuneja101003 No worries, feel free to ask your question , please update the existing file instead of creating a new one. |
@Kushal997-das |
Hi @KashishJuneja101003 , I noticed that you've already cloned the project. Could you please update the existing .py file with the necessary changes instead of creating a new file? Thank you! |
Kindly review my pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KashishJuneja101003 ,
I wanted to address a logical inconsistency regarding the dates provided. A date of birth (DOB) of 10/10/2003 (October 10, 2003) cannot occur before today's date of 03/10/2003 (March 10, 2003) within the same year.
To clarify:
- DOB: 10/10/2003 indicates the person was born on October 10, 2003.
- Today's Date: 03/10/2003 signifies it is March 10, 2003.
Since the DOB falls later in the year than todayโs date, it is not possible for someone to be born on October 10, 2003, before March 10, 2003.
Given this clarification, I will be closing this PR and issue.
Thank you for your understanding.
I noticed there's some conflict arising. Can you please take a moment to discuss and resolve it? Thanks! |
I resolved this issue. |
@KashishJuneja101003 Hurray, your PR got merged into our Project-Guidance ๐ฅณ. Thanks a bunch. Feel free to take another Issue. ๐ |
Project-Guidance! ๐๐
Welcome! ๐
Thank you for visiting our repository! We're excited to have you here. If you find this project useful, please consider giving it a star! โญ
๐ Have you reviewed the Contributing Guidelines? ๐ค (Required)
๐ Description
I refactored the existing code in age.py to improve the accuracy and readability of the age calculation logic. Specifically, I addressed the following points:
๐ง Fixes #issue_no (Required)
Issue number #1358
๐ท๏ธ Initiative Participation (Required)
This pull request is associated with the following initiative. Please choose the one you are contributing to: