Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature added #929

Closed
wants to merge 1 commit into from
Closed

Feature added #929

wants to merge 1 commit into from

Conversation

payallenka
Copy link

Now, the google clone can be in any language.

@github-actions github-actions bot requested a review from Kushal997-das October 9, 2023 22:27
Copy link
Owner

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@payallenka Kindly raise the issue first then raise a PR , make sure describe what you have changes there .

@Kushal997-das Kushal997-das added the Under-review Your code is in under review. label Oct 11, 2023
@payallenka
Copy link
Author

I have raised an issue, and the required steps previously.

Issue being: (Kindly check the same)
Title: Adding google translator feature to 'Google clone' project #918

@payallenka
Copy link
Author

payallenka commented Oct 12, 2023 via email

Copy link
Owner

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@payallenka Hello Payal do deploy the project and add the project link in readme.md section.

@payallenka
Copy link
Author

payallenka commented Oct 12, 2023

Hello @Kushal997-das I don't have an idea about the above.

@Kushal997-das
Copy link
Owner

Kushal997-das commented Oct 12, 2023 via email

@payallenka
Copy link
Author

The link is already added in the Readme.md file. The changes will be visible once the PR is merged in the main project.
Thank you.

@Kushal997-das
Copy link
Owner

The link is already added in the Readme.md file. The changes will be visible once the PR is merged in the main project. Thank you.

The updated link is not present, here you need to deploy this project and then put the link in the readme.md file in order to see others.

@payallenka
Copy link
Author

payallenka commented Oct 14, 2023 via email

@Kushal997-das
Copy link
Owner

Yeah, and i actually don’t know how to deploy it. Yet to learn it. Is there anything else I can do?

On Sat, 14 Oct 2023 at 9:51 AM, Kushal Das @.> wrote: The link is already added in the Readme.md file. The changes will be visible once the PR is merged in the main project. Thank you. The updated link is not present, here you need to deploy this project and then put the link in the readme.md file in order to see others. — Reply to this email directly, view it on GitHub <#929 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT6EWIZC4QEDDVACBSBEM6TX7IHLZANCNFSM6AAAAAA5ZNK6CM . You are receiving this because you were mentioned.Message ID: @.>

@payallenka Hello Look into this

@payallenka
Copy link
Author

@Kushal997-das
image

a little guidance here please

@Kushal997-das
Copy link
Owner

Kushal997-das commented Oct 18, 2023 via email

@Kushal997-das
Copy link
Owner

@payallenka Update on this else your PR gonna be close.

@payallenka
Copy link
Author

payallenka commented Oct 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deadline-over. Under-review Your code is in under review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants