Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛🪲 Prevent edge case where MAG completeness is incorrectly computed #255

Open
evanroyrees opened this issue Apr 5, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@evanroyrees
Copy link
Collaborator

evanroyrees commented Apr 5, 2022

Prevent edge case where MAG completeness will be incorrectly computed. This occurs when all single-copy markers are not represented in the respective metagenome assembly. This causes the reference_markers_count value to be lower than its actual count, thereby incorrectly increasing the completeness estimation.

The MAG QA metrics of completeness will be incorrectly assessed if not all of the single-copy markers are represented at least once in the overall metagenome marker annotation

reference_markers_count = markers_df.shape[1]

@evanroyrees evanroyrees added the bug Something isn't working label Apr 5, 2022
@evanroyrees evanroyrees changed the title 🐛🪲 Prevent edge case where all single-copy markers are not represented in metagenome assembly 🐛🪲 Prevent edge case where MAG completeness is incorrectly computed Apr 5, 2022
@evanroyrees evanroyrees pinned this issue May 6, 2022
@kaw97 kaw97 unpinned this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant