From 1eefb6fbc1b084a62d728ea0d8b4d2943b2d67bc Mon Sep 17 00:00:00 2001 From: Cterry45 Date: Mon, 23 Oct 2023 16:09:47 +0100 Subject: [PATCH] KXI-30038: Testing new naming convention --- .github/workflows/prod_release.yml | 9 +++++++-- release_process.md | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/prod_release.yml b/.github/workflows/prod_release.yml index 914875a1..8ae95064 100644 --- a/.github/workflows/prod_release.yml +++ b/.github/workflows/prod_release.yml @@ -74,6 +74,11 @@ jobs: needs: app-sec runs-on: ubuntu-latest steps: + - name: Set Tag Var + id: vars + run: | + VERSION=${{ github.ref_name }} + echo "run_tag=$(echo ${VERSION:1})" >> $GITHUB_OUTPUT - name: Checkout code uses: actions/checkout@v2 with: @@ -101,8 +106,8 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: upload_url: ${{ steps.create_release.outputs.upload_url }} - asset_path: kdb-${{ github.ref_name }}.vsix - asset_name: kdb-${{ github.ref_name }}.vsix + asset_path: kdb-${steps.vars.outputs.run_tag}.vsix + asset_name: kdb-${steps.vars.outputs.run_tag}.vsix asset_content_type: application/octet-stream # manual-approve: diff --git a/release_process.md b/release_process.md index 16261aa9..d546453f 100644 --- a/release_process.md +++ b/release_process.md @@ -6,7 +6,7 @@ On each push to Main or Dev there is a vsix built and uploaded to [Downloads Por 1. Update the [package.json](package.json) to bump the version for the extension. This is important because when installing the package (VSIX), it's important to have the updated version to ensure VSCode does not install another version. This applies after the extension is published to the marketplace. This uses semantic version of build.release.patch (e.g., 0.1.8) -2. Update the [CHANGELOG.md](CHANGELOG.md) to include the release version the the appropriate comments on updates. +2. Update the [CHANGELOG.md](CHANGELOG.md) to include the release version the the appropriate comments on updates. This uses semantic version of build.release.patch (e.g., v0.1.8) 3. Merge the changes