Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms using Blade and the @sessionToken directive don't work #239

Closed
SebKay opened this issue Nov 22, 2023 · 4 comments
Closed

Forms using Blade and the @sessionToken directive don't work #239

SebKay opened this issue Nov 22, 2023 · 4 comments
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet

Comments

@SebKay
Copy link

SebKay commented Nov 22, 2023

I've just upgrade to v19.1.0 (from the old Osiset package) and whenever I submit a form that uses the @sessionToken Blade directive, the page just hangs (see screenshot).

Screenshot 2023-11-22 at 21 04 15

The controller is actually processed because the code in my controller method is being run, it's the redirect after that which fails.

It appears the issue is with Redirect::tokenRedirect().

So far as I can tell, it hits the authenticate/token route and gets stuck (I figured that bit out thanks to Laravel Debugbar).

It's worth noting there's nothing in the error log either.

Do you have any idea why this might be happening and what I can do to fix it?

@SebKay SebKay added bug Something isn't working unconfirmed Bug has not been reproduced yet labels Nov 22, 2023
@Kyon147
Copy link
Owner

Kyon147 commented Dec 6, 2023

This should be fixed in 19.2.0 now, can you upgrade and try. Re-open if still and issue.

@Kyon147 Kyon147 closed this as completed Dec 6, 2023
@SebKay
Copy link
Author

SebKay commented Dec 6, 2023

Yep! Seems to be fixed.

Just a heads up, this is still an issue when using an app via the new Shopify admin URL, but if you're app is on the old URL then it works fine.

@SebKay
Copy link
Author

SebKay commented Dec 7, 2023

OK, upon testing this is still an issue, however now it's intermittent instead of all the time.

@Kyon147 Are you able to re-open? I can't do so by the looks of it.

@SebKay
Copy link
Author

SebKay commented Dec 13, 2023

Opened a new issue for this, #248.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

2 participants