Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gnikyt/Basic-Shopify-API with Shopify/shopify-api-php #374

Open
badger-adam opened this issue Dec 16, 2024 · 2 comments
Open

Replace gnikyt/Basic-Shopify-API with Shopify/shopify-api-php #374

badger-adam opened this issue Dec 16, 2024 · 2 comments
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet

Comments

@badger-adam
Copy link

badger-adam commented Dec 16, 2024

I have concerns that the https://github.com/gnikyt/Basic-Shopify-API package hasn't had a new release in over 2 years. I think we should look at dropping it as a requirement to use https://github.com/Shopify/shopify-api-php instead. I think it will fix many issues we have with updates to Shopify API long term.

@Kyon147 If you are in agreement, I will try to find time to help with this. Our company may become more reliant on this package in the future.

@badger-adam badger-adam added bug Something isn't working unconfirmed Bug has not been reproduced yet labels Dec 16, 2024
@enmaboya
Copy link
Contributor

The package https://github.com/Shopify/shopify-api-php is updated only slightly more often, and the updates that have been made didn’t really change much.
I think Shopify is not very interested in PHP; they are focused on Remix.

Moreover, the shopify-api-php package itself isn’t very well written.


As for the https://github.com/gnikyt/Basic-Shopify-API package, I’ve been maintaining it for some time now, removing legacy code and trying to fix known bugs. I think it will be ready after the New Year.

@Kyon147
Copy link
Owner

Kyon147 commented Dec 18, 2024

@badger-adam I think there's not many options out there and at the moment I don't really want to add another requirement to this package that needs to be maintained internally.

I think unless there's an urgent issue with the Basic API package, we can continue to use it as it is just a wrapper so I can't foresee to many issues with using it, unless I am missing something?

Edit: If there is a better alternative though like @enmaboya suggests that does not cause any breaking changes then I am open to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

3 participants