Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security vulnerability? #33

Open
MrEgggga opened this issue May 5, 2022 · 1 comment
Open

security vulnerability? #33

MrEgggga opened this issue May 5, 2022 · 1 comment

Comments

@MrEgggga
Copy link

MrEgggga commented May 5, 2022

almost definitely the wrong place but i got a high security vulnerability when installing this package GHSA-926x-m6m5-3mmp (seems to not show up in the Security tab, i don't know how these things work)

@BigBlueHat
Copy link

Looks like the branch variable on this line just needs validating to be a "clean" branch name to avoid someone using that to inject other command line commands:
https://github.com/L33T-KR3W/push-dir/blob/master/index.js#L139

The regex from this StackOverflow post looks helpful/promising:

^(?!@$|build-|/|.*([/.]\.|//|@\{|\\))[^\000-\037\177 ~^:?*[]+/[^\000-\037\177 ~^:?*[]+(?<!\.lock|[/.])$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants