Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typehinting luasnip #1117
Typehinting luasnip #1117
Changes from 5 commits
977f45d
e22c16b
01b6c54
5946701
72c2348
7360ae1
a1fa193
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this gave me a few thoughts:
trigger
,name
,description
,captures
andenv
would be official, or are so commonly-used that they won't be changed, while stuff likeid
andwordTrig
should not (yet) be relied upon.Also, there are a few interesting functions for snippet, see here
Snippet
, we should probably use a separate file for basic classes like that (seelua/luasnip/_types.lua
orlua/luasnip/extras/_extra_types.lua
for examples of this) (also, looking at them, it may make sense to namespace our classes 😅)snip_expand
would take anexpandable
. But since this distinction exists in very few places, and is yet another thing newcomers would have to deal with, it's probably fine, especially for now, to just make most thingsSnippet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(correction:
id
can also be official 😅 Just saw that we haveget_id_snippet
, and that'd be pretty stupid without some way to get theid
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we'll also need a
Node
-type, first for arguments like this, and second to communicate API (which is currently described here)