-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add condition SNR estimation #273
Comments
Am I correct that what you've called |
I think it would be pretty useful, but here are a couple questions:
|
It's also used to know which
Yes after the basic one (
That example does temporal generalization to generate the bottom image plot, which is slower. Timing just the time-resolved decoding from that example on my machine I get 1.5 sec, the time-generalization computation (which we wouldn't do here) takes 8 sec.
Nice, it's clear it needs to be a pair, changed the top comment |
OK, maybe leave as-is then. |
@NeuroLaunch any interest in trying this one next? :) |
@larsoner this slipped past my email alerts from GitHub, so I'm just seeing your request now. I'm definitely up for it! |
Okay feel free to give it a shot, if the API or implementation is not clear in your mind (after some thinking on it) let me know and we can hash it out here or on Slack, probably with @drammock because he has a good eye for API design |
One way to get a handle on single-subject SNR is to compute the sliding estimator as a function of time between two conditions, as in:
https://mne.tools/dev/auto_tutorials/machine-learning/plot_sensors_decoding.html#temporal-decoding
I propose adding a new
report
argumenttime_decoding
that is a dict. Forfunloc
this could be for example:This would add a single plot to the report which is the time-resolved decoding for the first condition versus the second using basically the same code as in the MNE example. Eventually (or from the start) this could be made into a list of dicts.
@drammock @ktavabi would you find this useful? Happy with the proposed YAML API?
This would be a good first
mnefun
PR for @NeuroLaunch in the coming weeks, feel free to comment as wellEDIT: Edited to incorporate @drammock's suggestions
The text was updated successfully, but these errors were encountered: