[WIP] Modified h5 reader for LASY #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This is still WIP, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
lasypackage, particularly focusing on the handling of OpenPMD profiles and improvements to thecreate_gridfunction. The changes aim to enhance functionality and improve code clarity.Updates to OpenPMD Profile Handling:
lasy/profiles/from_openpmd_profile.py: Removed the dependency onOpenPMDTimeSeriesand replaced it with direct usage ofopenpmd_api. This change simplifies the process of reading laser field data from OpenPMD files.lasy/profiles/from_openpmd_profile.py: Refactored theFromOpenPMDProfileclass to remove unused parameters and streamline the initialization process. The class now directly reads data usingopenpmd_apiand handles different field dimensions ('rt' and 'xyt').Improvements to Utility Functions:
lasy/utils/laser_utils.py: Modified thecreate_gridfunction to usenp.allcloseinstead ofnp.allfor comparing grid axes. This change ensures that the comparisons are tolerant to small numerical differences, improving robustness.