You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recob::OpWaveform is an intermediate class between raw::OpDetWaveform and recob::OpHits. Right now raw::OpDetWaveform provides a timestamp of double type, and recob::OpHits require also a double, however recob::OpWaveform stores the timestamp as a raw::RDTimeStamp.
There is a PR in duneopdet to implement this class, and we are forced to read raw::OpDetWaveforms just to take the timestamp when creating OpHits, which looks quite inefficient: DUNE/duneopdet#27 (comment)
The timestamp type should be changed from recob::raw::RDTimeStamp to a double, or add a new member to store this double.
Recob::OpWaveform is an intermediate class between raw::OpDetWaveform and recob::OpHits. Right now raw::OpDetWaveform provides a timestamp of double type, and recob::OpHits require also a double, however recob::OpWaveform stores the timestamp as a raw::RDTimeStamp.
There is a PR in duneopdet to implement this class, and we are forced to read raw::OpDetWaveforms just to take the timestamp when creating OpHits, which looks quite inefficient:
DUNE/duneopdet#27 (comment)
The timestamp type should be changed from recob::raw::RDTimeStamp to a double, or add a new member to store this double.
lardataobj/lardataobj/RecoBase/OpWaveform.h
Line 104 in d14ec2d
The text was updated successfully, but these errors were encountered: