Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case sensitive functionality #69

Open
smolins opened this issue Aug 24, 2020 · 0 comments
Open

case sensitive functionality #69

smolins opened this issue Aug 24, 2020 · 0 comments

Comments

@smolins
Copy link
Collaborator

smolins commented Aug 24, 2020

There is no information about whether engines cannot take in case sensitive strings, in particular condition labels. (reported by @lipnikov)

Neither CrunchFlow nor PFLOTRAN are case-sensitive for condition labels. The problem with CrunchFlow was that I did not implement the appropriate function in the Crunchflow alquimia interface. Technically, a bug. Fixed in pull request  (closes #68)

We need to add a new functionality variable that tells the user whether one can pass driver-derived strings as case sensitive or not. Engine-derived strings may need to be assumed case-sensitive.

We need to decide how general this variable can be (task: go over every string that goes into Alquimia). At the very least, the variable will indicate whether condition%name is case-sensitive or not, e.g. "bool functionality%label_case_sensitive".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant