Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlalchemy and/or pandas dependency #45

Open
evaneill opened this issue Mar 28, 2024 · 1 comment
Open

Update sqlalchemy and/or pandas dependency #45

evaneill opened this issue Mar 28, 2024 · 1 comment

Comments

@evaneill
Copy link
Collaborator

The current setup.py fixes the sqlalchemy requirement at 1.4.29, though for versions of pandas ≥2.2.0 (which is not restricted in setup.py), this will result in some adapter dependents no longer working.

It seems to make sense to commit to having dependents of adapter become compatible with pandas ≥2.2.0, and then commit to updating adapter to require pandas≥2.2.0 and newer sqlalchemy.

Related to this issue, which is a matter of newer versions of pandas requiring newer versions of openpyxl.

@lyralan
Copy link
Collaborator

lyralan commented Jul 1, 2024

Related to upgrading pandas to 2.2.0+, numexpr and bottleneck need to be higher than 2.8.4 and 1.3.6 respectively to avoid user warnings. It might also make sense to add requirements for other related packages (e.g., seaborn ≥0.13.2, xlsxwriter ≥3.0.5, scipy ≥1.13.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants