Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyradiance arm64 build should be named universal? #36

Open
Andrej730 opened this issue Jul 16, 2024 · 1 comment
Open

pyradiance arm64 build should be named universal? #36

Andrej730 opened this issue Jul 16, 2024 · 1 comment

Comments

@Andrej730
Copy link

Hi, just noticed that current build pyradiance-0.4.1-py3-none-macosx_11_0_arm64.whl from pypi seems to have both arm64 and intel x86_64 binaries in it.

Is it intentional and it should be named _universal2.whl instead of _arm64.whl then? Or it's a bug and it should have only arm64 binaries?

pip install pyradiance --platform macosx_11_0_arm64 --python-version 3.11 --implementation cp --only-binary=:all: --target=./site-packages
file .\site-packages\pyradiance\libraycalls.so
# .\site-packages\pyradiance\libraycalls.so: Mach-O universal binary with 2 architectures: 
# [x86_64: Mach-O 64-bit x86_64 bundle, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL>]
# [arm64: Mach-O 64-bit arm64 bundle, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL>]
@taoning
Copy link
Collaborator

taoning commented Jul 16, 2024

libraycalls.so is the shared library for Radiance C function calls and they might be universal due to the way it's created, but I have not tested.
Majority of the function however uses binaries inside the bin directory and those should be arch specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants