Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❗ Remaining issues in the BioHackrXiv manuscript #54

Open
5 tasks
matuskalas opened this issue Jun 28, 2023 · 2 comments
Open
5 tasks

❗ Remaining issues in the BioHackrXiv manuscript #54

matuskalas opened this issue Jun 28, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@matuskalas
Copy link
Collaborator

matuskalas commented Jun 28, 2023

Dear @NuriaQueralt @LBolzani, I merged and fixed (and merged, and fixed, *) what I could, in #46.

It looks like this: paper.pdf

PLEASE @NuriaQueralt @LBolzani TODO:

  • Review and merge Update requirements.txt #48 (@LBolzani?)
  • Improve the resolution of all figures, especially figures 3-5. Figures 1-2 could perhaps be better as vector graphics (svg, pdf, whatever works with the biohackrxiv generator)
  • In figures 3-5 also remove the white sides and make them full-width (adding width=100% didn't help)
  • Are all the co-authors now included accordingly in the Contributions section? E.g. DC?
  • Is it an intention that the Acknowledgements section acknowledges also people who are co-authors?
@matuskalas matuskalas added the help wanted Extra attention is needed label Jun 28, 2023
@matuskalas matuskalas assigned LBolzani and unassigned LBolzani Jun 28, 2023
@NuriaQueralt
Copy link
Contributor

Dear @matuskalas,

Thank you so so much for your very nice and careful revision. The paper looks very good. Wrt the 5 listed issues, I think I will go for fixing the last two ones, 4-5, after touching base wth DC and other co-authors.

With kind regards,
Núria

@NuriaQueralt
Copy link
Contributor

Dear @matuskalas and @LBolzani,

I have just reviewed the last two problems Matus raised in his issue, and sent a PR to Luca.

You can keep this issue open until we don't solve 1-3 problems.

Kind regards,
n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants