Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leave units blank by default #53

Open
jchate6 opened this issue May 12, 2023 · 2 comments
Open

leave units blank by default #53

jchate6 opened this issue May 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jchate6
Copy link
Contributor

jchate6 commented May 12, 2023

We should not autofill the brightness units. Users should have to fill this in themselves.
This will also hopefully mean that these values will not autofill in the JSON and text version.

Specifically, brightness_unit, limiting_brightness_unit, ra_error_units, and dec_error_units are an issue.

This is a function of how we do drop downs.
The best solution in my opinion is to leave all of these blank and un-validated unless the corresponding value is present.
i.e. there is no limiting_brightness_unit unless a limiting_brightness is supplied.

At the very least we should hide them from the text view.

@jchate6 jchate6 added the bug Something isn't working label May 12, 2023
@jchate6 jchate6 changed the title leave brightness units blank by default leave units blank by default May 12, 2023
@jnation3406
Copy link
Contributor

@jchate6 Do you mean that those units should not be required, i.e. you should be allowed to submit a brightness without a brightness unit? Or should it still be required but only if a brightness has been filled in? I agree in principle that they should not be filled in by default, just trying to hash out the specifics before I change it.

@jchate6
Copy link
Contributor Author

jchate6 commented Sep 23, 2023

@jnation3406 Thanks for checking. The second option was what I was thinking. They should definitely be required if a corresponding value is present, but be blank until a user makes a selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants