Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hcal prototype in reduced LDMX #1515

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Update hcal prototype in reduced LDMX #1515

wants to merge 2 commits into from

Conversation

cmantill
Copy link
Contributor

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1512

Check List

@tvami tvami marked this pull request as draft January 17, 2025 21:40
@tvami tvami marked this pull request as ready for review January 17, 2025 21:40
@tvami
Copy link
Member

tvami commented Jan 18, 2025

so when we try to run this inside ldmx-sw we get

Evaluator : unknown variable
Aborted (core dumped)

I looked for hours now which of these could be unknown, but I didnt find it :/

@cmantill
Copy link
Contributor Author

What kind of test is running that gives: "Evaluator : unknown variable"?

@tvami
Copy link
Member

tvami commented Jan 18, 2025 

wget https://raw.githubusercontent.com/LDMX-Software/ldmx-sw/e375990bf13c7073634bf2eab3bff7e84a9d991b/.github/validation_samples/reduced_ldmx/config.py
just setenv LDMX_NUM_EVENTS=1
just setenv LDMX_RUN_NUMBER=1
just fire config.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjitMasanam SanjitMasanam Awaiting requested review from SanjitMasanam

@tvami tvami Awaiting requested review from tvami

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the HCAL demonstrator into the ldmx-reduced-v2
2 participants
@cmantill @tvami