add option to set default container pull policy

cmd/config.go

@@ -15,6 +15,7 @@ import (
 	"github.com/spf13/viper"
 
 	"github.com/LINBIT/virter/internal/virter"
+	"github.com/LINBIT/virter/pkg/pullpolicy"
 	"github.com/LINBIT/virter/pkg/sshkeys"
 )
 
@@ -92,6 +93,10 @@ user_public_key = "{{ get "auth.user_public_key" }}"
 [container]
 # provider is the container engine used. Can be either podman or docker.
 provider = "{{ get "container.provider" }}"
+
+# default pull policy to apply if non was specified. Can be 'Always', 'IfNotExist' or 'Never'.
+# Default value: "{{ get "container.pull" }}"
+pull = "{{ get "container.pull" }}"
 `
 
 // initConfig reads in config file and ENV variables if set.
@@ -105,6 +110,7 @@ func initConfig() {
 	viper.SetDefault("time.shutdown_timeout", 20*time.Second)
 	viper.SetDefault("auth.user_public_key", "")
 	viper.SetDefault("container.provider", "docker")
+	viper.SetDefault("container.pull", "IfNotExist")
 
 	viper.SetConfigType("toml")
 	if cfgFile != "" {
@@ -225,3 +231,19 @@ func getReadyConfig() virter.VmReadyConfig {
 		CheckTimeout: viper.GetDuration("time.ssh_ping_period"),
 	}
 }
+
+func getDefaultContainerPullPolicy() pullpolicy.PullPolicy {
+	opt := viper.GetString("container.pull")
+
+	if opt == "" {
+		return pullpolicy.IfNotExist
+	}
+
+	var policy pullpolicy.PullPolicy
+	err := policy.UnmarshalText([]byte(opt))
+	if err != nil {
+		log.WithError(err).Fatal("invalid default pull policy")
+	}
+
+	return policy
+}

cmd/image_build.go

@@ -134,6 +134,7 @@ func imageBuildCommand() *cobra.Command {
 			provOpt := virter.ProvisionOption{
 				FilePath:           provisionFile,
 				Overrides:          provisionOverrides,
+				DefaultPullPolicy:  getDefaultContainerPullPolicy(),
 				OverridePullPolicy: containerPullPolicy,
 			}
 

cmd/vm_exec.go

@@ -34,6 +34,7 @@ func vmExecCommand() *cobra.Command {
 			provOpt := virter.ProvisionOption{
 				FilePath:           provisionFile,
 				Overrides:          provisionOverrides,
+				DefaultPullPolicy:  getDefaultContainerPullPolicy(),
 				OverridePullPolicy: containerPullPolicy,
 			}
 			if err := execProvision(ctx, provOpt, args); err != nil {

cmd/vm_run.go

@@ -245,6 +245,7 @@ func vmRunCommand() *cobra.Command {
 				provOpt := virter.ProvisionOption{
 					FilePath:           provisionFile,
 					Overrides:          provisionOverrides,
+					DefaultPullPolicy:  getDefaultContainerPullPolicy(),
 					OverridePullPolicy: containerPullPolicy,
 				}
 				if err := execProvision(ctx, provOpt, vmNames); err != nil {

internal/virter/provision.go

@@ -93,6 +93,7 @@ func EnvmapToSlice(envMap map[string]string) []string {
 type ProvisionOption struct {
 	FilePath           string
 	Overrides          []string
+	DefaultPullPolicy  pullpolicy.PullPolicy
 	OverridePullPolicy pullpolicy.PullPolicy
 }
 
@@ -154,7 +155,7 @@ func newProvisionConfigReader(provReader io.Reader, provOpt ProvisionOption) (Pr
 			}
 
 			if s.Docker.Pull == "" {
-				s.Docker.Pull = pullpolicy.IfNotExist
+				s.Docker.Pull = provOpt.DefaultPullPolicy
 			}
 
 			if provOpt.OverridePullPolicy != "" {

internal/virter/provision_test.go

@@ -198,7 +198,7 @@ foo = "{{.ShellEnv"
 						Image:   "some-image",
 						Command: []string{"exit", "0"},
 						Env:     map[string]string{"foo": "bar"},
-						Pull:    pullpolicy.IfNotExist,
+						Pull:    "",
 					},
 				},
 				ProvisionStep{