Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sidre-to-conduit hierarchy copies #1517

Open
gunney1 opened this issue Mar 5, 2025 · 1 comment
Open

Support sidre-to-conduit hierarchy copies #1517

gunney1 opened this issue Mar 5, 2025 · 1 comment
Labels
enhancement New feature or request Reviewed Sidre Issues related to Axom's 'sidre' component

Comments

@gunney1
Copy link
Contributor

gunney1 commented Mar 5, 2025

Some tools and interfaces support only sidre hierarchies or conduit hierarchies. To use a combination of them, we need to switch seamlessly between the 2 hierarchy types. This means deep copying and shallow-copying between the two. Four methods needed (2 are currently supported):

  1. Deep copy conduit to sidre: Group::importConduitNode
  2. Deep copy sidre to conduit: Missing
  3. Shallow copy conduit to sidre: Missing
  4. Shallow copy sidre to conduit: Group::createNativeLayout

We should implement the missing methods.

Sidre and Conduit have ways to specify an allocator id for a hierarchy node. The deep copy should respect the value set for the destination node and propagate it down the destination hierarchy.

@gunney1 gunney1 added enhancement New feature or request Sidre Issues related to Axom's 'sidre' component labels Mar 5, 2025
@nselliott
Copy link
Contributor

For a shallow copy of conduit to sidre, the resulting sidre hierarchy would have to have all external views for its leaves, as the data would already be allocated and owned elsewhere, either by conduit or by someone else using conduit's external data support. This is not to discourage an implementation, as this should be useful functionality to provide more complete interoperability between the libraries, though anyone using it will need to exercise the extra care needed to avoid errors with the pointers to external data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Reviewed Sidre Issues related to Axom's 'sidre' component
Projects
None yet
Development

No branches or pull requests

3 participants