Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P-alpha porosity #246

Merged
merged 152 commits into from
Dec 21, 2023
Merged

P-alpha porosity #246

merged 152 commits into from
Dec 21, 2023

Conversation

jmikeowen
Copy link
Collaborator

@jmikeowen jmikeowen commented Nov 21, 2023 •
edited
Loading

Summary

  • This PR is adds a new porosity model based on a P-alpha (pressure-distention) relationship.
  • It does the following:
    • P-alpha and strain-alpha are now both supported.
    • We've added a new Porosity package with all porosity modeling support moved into this location. Also a new PorosityModel base class for common features to P-alpha and strain-alpha.
    • Refactored how porosity is maintained in the State and participates in updating other physics variables. The PorousEquationOfState and PorousStrengthModel are gone, though for backwards compatibility Python classes take their place and issue deprecation warnings.
    • Refactored the use of UpdatePolicies and how they relate to FieldLists.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

jmikeowen added 30 commits August 29, 2023 15:13
@jmikeowen
Adding new EOS requirement to compute dPdrho and dPdu for use with
c779812 
P-alpha porosity model
@jmikeowen
We updated the Gruniesen implementation again (putting the cold limit
590be60 
back in -- keep going back and forth on this). This required updating
the reference data for this test.
@jmikeowen
Initial implementation of P-alpha model -- untested.
9646d56
@jmikeowen
Adding some Python convenience functions to cast between py::list and
4ebf851 
std::vector in constructors
@jmikeowen
Contract bugfix
86c819d
@jmikeowen
Adding porosity (phi) as computed output from porosity models that
945d394 
store distension (alpha).
@jmikeowen
Working on a P-alpha test problem
03e592b
@jmikeowen
Protecting from negative sound speed when porosity is growing.
50e9fc7
@jmikeowen
Checkpoint
cc3d6d9
@jmikeowen
Initial Python bindings for generic state update policies
c8940ba
@jmikeowen
Checkpoint
3ae1e4a
@jmikeowen
Checkpoint
bc69013
@jmikeowen
Adding a bunch of the hydro update policies. Also a bit of
7d2c886 
housecleaning of old unused stuff.
@jmikeowen
Fixing an error in DataBase python bindings
60c0147
@jmikeowen
Converting all our basic update policies to be entirely inlined.
26ee687 
Helps with Python binding, and makes use of new updated state types simpler.
@jmikeowen
Contract fix
3e232bf
@jmikeowen
Starting a new porosity test to force the evolution of a single point
790b1a8 
phi and compare with an analytic solution
@jmikeowen
Checkpoint
e1c01f1
@jmikeowen
Found some errors in the P-alpha plastic evolution
425e358
@jmikeowen
Added a more complicated scenario to our P-alpha porosity unit test
b6a9d20 
with compression and expansion.  Results look good.
@jmikeowen
Checkpoint
cbd77ce
@jmikeowen
Checkpoint
c489c5b
@jmikeowen
Modernizing the shadow Gruneisen EOS interface a bit.
1dfac16
@jmikeowen
Converted the planar P-alpha compression test to be in the initial
bd70da5 
moving frame, which let's us use more natural boundary conditions.
@jmikeowen
Adding more material options for aluminum
ecaf6e9
@jmikeowen
Cleaning up and correcting a few minor problems in the Tillotson
e1fe0d2
@jmikeowen
Adding a timestep constraint for P-alpha porosity. Planar compaction
1b80939 
test still shows problems.
@jmikeowen
Requiring C++17
1248239
@jmikeowen
More timestep control for P-alpha
72b9bf8
@jmikeowen
Strange results for analytic EOS's still
18a8420
@jmikeowen jmikeowen marked this pull request as ready for review December 9, 2023 00:51
jmpearl
jmpearl reviewed Dec 9, 2023
View reviewed changes
src/Material/GammaLawGas.cc Outdated Show resolved Hide resolved
@jmpearl
Copy link
Collaborator

jmpearl commented Dec 10, 2023

The DEM, FSISPH, and GSPH edits all look good

ldowen
ldowen previously approved these changes Dec 13, 2023
View reviewed changes
scripts/spack/configs/x86_64/packages.yaml Show resolved Hide resolved
mdavis36
mdavis36 requested changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@mdavis36 mdavis36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of changes that need to be reverted, but after that I think this is good to go.

.gitlab/machines.yml Outdated Show resolved Hide resolved
.gitlab/scripts.yml Outdated Show resolved Hide resolved
@jmikeowen jmikeowen requested a review from mdavis36 December 15, 2023 19:36
mdavis36
mdavis36 previously approved these changes Dec 18, 2023
View reviewed changes
@jmikeowen
Making P-alpha robust when handed an empty NodeList. Also turning off
9caf9cb 
porosity time step control by default (can still be turned on
manually), so we depend on the normal hydro time step constraints.
P-alpha was too restrictive.
jmpearl
jmpearl approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@jmpearl jmpearl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@jmikeowen jmikeowen merged commit 1c1c820 into develop Dec 21, 2023
2 checks passed
@jmikeowen jmikeowen deleted the feature/Palpha_porosity branch December 21, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmpearl jmpearl jmpearl approved these changes

@ldowen ldowen ldowen approved these changes

@mdavis36 mdavis36 mdavis36 left review comments

Assignees

@jmikeowen jmikeowen

Labels
None yet
Projects
None yet
Milestone
2024.01.0 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@jmikeowen @jmpearl @mdavis36 @ldowen