Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/value view interface #282

Merged
merged 14 commits into from
Jul 22, 2024
Merged

Feature/value view interface #282

merged 14 commits into from
Jul 22, 2024

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Jul 2, 2024

Summary

  • This PR is a (refactoring, bugfix, feature, something else)
  • It does the following:
    • Modifies / refactors (class or method) (how?)
    • Fixes (issue number(s))
    • Adds (specific feature) at the request of (project or person)

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

mdavis36 added 14 commits June 10, 2024 20:34
@mdavis36
Merge branch 'develop' into feature/value-view-interface
bd103bb
@mdavis36
Adding Chai as a submodule
7999e8e
@mdavis36
Reproducable axom link failure with empty shared cuda library.
6093636
@mdavis36
Fixing bad cuda shared library link; CMake behavior interacts badly a…
2171122 
…fter 3.14 w/ latest BLT.
@mdavis36
Merge branch 'bugfix/axom-link' into feature/value-view-interface
85ed3db
@mdavis36
Fixing issue with new Axom in polyhedron test; Cleaning up object lib…
2893ad4 
… dependent target Spheral_CXX properties; Bringing in Axom correctly; Bringing in chai, raja and umpire through CMake.
@mdavis36
Move TPL build to separate stage from Spheral build.
0b8dccf
@mdavis36
Define tpl stage and job dependencies on tpl stage.
caca43a
@mdavis36
Adding artifacts to TPLs stage for passing firectory and job-name to …
e0b9a60 
…next stage...
@mdavis36
Case where extra CMake args is an empty string.
e0c07b1
@mdavis36
Do not define EXTRA_CMAKE_ARGS for empty specs; Remove quotes from sc…
34010d6 
…ripts call in build stage.
@mdavis36
Squashed warnings from CHAI.
20278ac
@mdavis36
Turning of trget cleanup for now, seems to trigger a failre when buil…
64518b8 
…ding wanrings as errors.
@mdavis36
Cleanup
1f50e9c
@mdavis36 mdavis36 merged commit 6f1d305 into develop Jul 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdavis36