You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I haven't checked whether that's the only name in SUNDIALS that has this problem, or whether that's a pattern. Either way, it's probably worth avoiding the issue, and because these names aren't part of the public interface, it shouldn't even be that difficult to rename things if you so chose.
The text was updated successfully, but these errors were encountered:
Unfortunately, SUNDIALS has used a leading underscore followed by an uppercase letter from the beginning so it is not limited to just _SUNContext. We can work towards changing these when they are not part of the public interface for now, and then look into fixing the others when a major release is on the horizon.
I am noting that the specific example mentioned has been resolved, but there are still a number of other places in SUNDIALS with this issue (and are in the public API). All new development in SUNDIALS avoids the reserved names though. We could consider changing existing ones for SUNDIALS 8.
The page at https://github.com/LLNL/sundials/blob/develop/doc/shared/sundials/SUNContext.rst describes the
Context
structure as declared as follows:This is unfortunate: Both C and C++ reserve all names that (i) start with an underscore, followed by an uppercase letter, (ii) start with two underscores. See https://en.cppreference.com/w/cpp/language/identifiers .
I haven't checked whether that's the only name in SUNDIALS that has this problem, or whether that's a pattern. Either way, it's probably worth avoiding the issue, and because these names aren't part of the public interface, it shouldn't even be that difficult to rename things if you so chose.
The text was updated successfully, but these errors were encountered: