Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed: Move factories to the same folder as the object they create #99

Closed
visto9259 opened this issue May 27, 2024 · 1 comment
Closed

Proposed: Move factories to the same folder as the object they create #99

visto9259 opened this issue May 27, 2024 · 1 comment
Labels
enhancement New feature or request v4 To be implemented in version 4
Milestone
4.0.0

Comments

@visto9259
Copy link
Member

Factories should be closer to the object that it is created. This is will help in understanding the code as one does not have to navigate to the Factory folder.

Refactor all the factories in Factory to the folder of the object that they are creating. For example, LmcRbacMvc\Factory\RoleServiceFactory should be refactored to LmcRbacMvc\Service\RoleServiceFactory.
Have the original factory extend the new factory and mark it as deprecated
Update ConfigProvider to use the new factories
@visto9259 visto9259 added enhancement New feature or request v4 To be implemented in version 4 labels May 27, 2024
@visto9259 visto9259 mentioned this issue May 27, 2024
Open
@visto9259 visto9259 moved this from 📋 To Do to 🏗 In progress in LmcRbacMvc Development May 27, 2024
visto9259 added a commit to visto9259/LmcRbacMvc that referenced this issue Aug 7, 2024
@visto9259
Move factories to the same folder as the class they are creating (LM-…
3354dc1 
…Commons#99)
@visto9259 visto9259 added this to the 4.0.0 milestone Aug 13, 2024
@visto9259 visto9259 mentioned this issue Aug 16, 2024
Merged
@visto9259
Copy link
Member Author

Fixed by #117

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in LmcRbacMvc Development Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v4 To be implemented in version 4
Projects
LmcRbacMvc Development
Status: ✅ Done
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@visto9259