From e4e243b64e98826349614ee19a4fae1d6aabeeba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Tue, 24 Dec 2024 11:23:30 +0100
Subject: [PATCH 1/9] improve exception handling

---
 LM-Kit-Maestro/Services/LMKitService.cs | 70 +++++++++++++------------
 1 file changed, 37 insertions(+), 33 deletions(-)

diff --git a/LM-Kit-Maestro/Services/LMKitService.cs b/LM-Kit-Maestro/Services/LMKitService.cs
index 37f57c4..e9c65ee 100644
--- a/LM-Kit-Maestro/Services/LMKitService.cs
+++ b/LM-Kit-Maestro/Services/LMKitService.cs
@@ -211,35 +211,20 @@ private async Task<LMKitResult> HandleLMKitRequest(LMKitRequest request)
         // Ensuring we don't touch anything until Lm-Kit objects' state has been set to handle this request.
         _lmKitServiceSemaphore.Wait();
 
-        LMKitResult result;
-
-        if (request.CancellationTokenSource.IsCancellationRequested || ModelLoadingState == LMKitModelLoadingState.Unloaded)
+        try
         {
-            result = new LMKitResult()
-            {
-                Status = LMKitTextGenerationStatus.Cancelled
-            };
+            LMKitResult result;
 
-            _lmKitServiceSemaphore.Release();
-        }
-        else
-        {
-            if (request.RequestType == LMKitRequest.LMKitRequestType.Prompt || request.RequestType == LMKitRequest.LMKitRequestType.RegenerateResponse)
+            if (request.CancellationTokenSource.IsCancellationRequested || ModelLoadingState == LMKitModelLoadingState.Unloaded)
             {
-                var conversation = request.RequestType == LMKitRequest.LMKitRequestType.Prompt ?
-                    ((LMKitRequest.PromptRequestParameters)request.Parameters!).Conversation :
-                    ((LMKitRequest.RegenerateResponseParameters)request.Parameters!).Conversation;
-
-                BeforeSubmittingPrompt(conversation);
-            }
-
-            _lmKitServiceSemaphore.Release();
+                result = new LMKitResult()
+                {
+                    Status = LMKitTextGenerationStatus.Cancelled
+                };
 
-            try
-            {
-                result = await SubmitRequest(request);
+                _lmKitServiceSemaphore.Release();
             }
-            finally
+            else
             {
                 if (request.RequestType == LMKitRequest.LMKitRequestType.Prompt || request.RequestType == LMKitRequest.LMKitRequestType.RegenerateResponse)
                 {
@@ -247,20 +232,39 @@ private async Task<LMKitResult> HandleLMKitRequest(LMKitRequest request)
                         ((LMKitRequest.PromptRequestParameters)request.Parameters!).Conversation :
                         ((LMKitRequest.RegenerateResponseParameters)request.Parameters!).Conversation;
 
-                    AfterSubmittingPrompt(conversation);
+                    BeforeSubmittingPrompt(conversation);
                 }
-            }
-        }
 
-        if (_requestSchedule.Contains(request))
-        {
-            _requestSchedule.Remove(request);
-        }
+                _lmKitServiceSemaphore.Release();
 
-        request.ResponseTask.TrySetResult(result);
+                try
+                {
+                    result = await SubmitRequest(request);
+                }
+                finally
+                {
+                    if (request.RequestType == LMKitRequest.LMKitRequestType.Prompt || request.RequestType == LMKitRequest.LMKitRequestType.RegenerateResponse)
+                    {
+                        var conversation = request.RequestType == LMKitRequest.LMKitRequestType.Prompt ?
+                            ((LMKitRequest.PromptRequestParameters)request.Parameters!).Conversation :
+                            ((LMKitRequest.RegenerateResponseParameters)request.Parameters!).Conversation;
+
+                        AfterSubmittingPrompt(conversation);
+                    }
+                }
+            }
 
-        return result;
+            request.ResponseTask.TrySetResult(result);
 
+            return result;
+        }
+        finally
+        {
+            if (_requestSchedule.Contains(request))
+            {
+                _requestSchedule.Remove(request);
+            }
+        }
     }
 
     private async Task<LMKitResult> SubmitRequest(LMKitRequest request)

From 7511c389ff5a0804a060700e778009052d134e49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Tue, 24 Dec 2024 11:23:43 +0100
Subject: [PATCH 2/9] improve model pannel page

---
 LM-Kit-Maestro/UI/Pages/ModelsPage.xaml         | 15 +++++++++------
 LM-Kit-Maestro/ViewModels/ModelInfoViewModel.cs |  4 ++++
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
index cf08b90..1a3b8ce 100644
--- a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
+++ b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
@@ -198,6 +198,7 @@
                             <ColumnDefinition Width="0.5*" />
                             <ColumnDefinition Width="0.5*" />
                             <ColumnDefinition Width="0.5*" />
+                            <ColumnDefinition Width="0.5*" />
                             <ColumnDefinition Width="0.2*" />
                         </Grid.ColumnDefinitions>
 
@@ -216,7 +217,6 @@
                                Text="{Binding ModelInfo.Publisher}"
                                ToolTipProperties.Text="{Binding ModelPath}"/>
 
-
                         <Label VerticalOptions="Center" 
                                Grid.Column="2" 
                                Text="{Binding ModelInfo.ModelName}"
@@ -264,17 +264,21 @@
 
                         <Label VerticalOptions="Center" 
                                Grid.Column="6" 
+                               Text="{Binding MaxContextLengthKB, StringFormat='{}{0:N0}k'}" 
+                               ToolTipProperties.Text="{Binding ModelInfo.ContextLength, StringFormat='This model supports a maximum context length of {0:N0} tokens'}" />
+
+                        <Label VerticalOptions="Center" 
+                               Grid.Column="7" 
                                ToolTipProperties.Text="{Binding Precision, StringFormat='This model uses {0}-bit precision, which indicates the number of bits used for numerical representation'}" 
                                Text="{Binding Precision}" />
 
-
                         <Label VerticalOptions="Center" 
-                               Grid.Column="7" 
+                               Grid.Column="8" 
                                HorizontalOptions="End" 
                                Text="{Binding FileSize, Converter={converters:FileSizeConverter}}"/>
-                        
+
                         <Button
-                            Grid.Column="8"
+                            Grid.Column="9"
                             Style="{StaticResource SecondaryActionButtonStyle}"
                             HorizontalOptions="End"
                             BackgroundColor="Transparent"
@@ -305,7 +309,6 @@
                                     </VisualStateGroup>
                                 </VisualStateGroupList>
                             </VisualStateManager.VisualStateGroups>
-
                         </Button>
                     </Grid>
                 </Border>
diff --git a/LM-Kit-Maestro/ViewModels/ModelInfoViewModel.cs b/LM-Kit-Maestro/ViewModels/ModelInfoViewModel.cs
index 09878b0..1271f54 100644
--- a/LM-Kit-Maestro/ViewModels/ModelInfoViewModel.cs
+++ b/LM-Kit-Maestro/ViewModels/ModelInfoViewModel.cs
@@ -53,6 +53,9 @@ public bool IsLocallyAvailable
         [ObservableProperty]
         float _compatibilityLevel;
 
+        [ObservableProperty]
+        int _maxContextLengthKB;
+
         [ObservableProperty]
         DownloadInfo _downloadInfo = new DownloadInfo();
 
@@ -78,6 +81,7 @@ public ModelInfoViewModel(ModelCard modelCard)
             IsMathModel = modelCard.Capabilities.HasFlag(ModelCapabilities.Math);
             ModelPath = modelCard.IsLocallyAvailable ? modelCard.LocalPath : modelCard.ModelUri.ToString();
             CompatibilityLevel = LMKit.Graphics.DeviceConfiguration.GetPerformanceScore(modelCard);
+            MaxContextLengthKB = modelCard.ContextLength / 1024;
         }
     }
 }

From 8b0d90931a91f235b4fb2e6afe1166ff4063471a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Tue, 24 Dec 2024 13:46:01 +0100
Subject: [PATCH 3/9] Slow models filtering

---
 LM-Kit-Maestro/Services/LLMFileManager.cs | 19 +++++++++++++++----
 LM-Kit-Maestro/UI/Pages/ModelsPage.xaml   |  2 +-
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/LM-Kit-Maestro/Services/LLMFileManager.cs b/LM-Kit-Maestro/Services/LLMFileManager.cs
index 6875f8a..b33c58f 100644
--- a/LM-Kit-Maestro/Services/LLMFileManager.cs
+++ b/LM-Kit-Maestro/Services/LLMFileManager.cs
@@ -26,13 +26,14 @@ public partial class LLMFileManager : ObservableObject, ILLMFileManager
     private readonly FileSystemEntryRecorder _fileSystemEntryRecorder = new FileSystemEntryRecorder();
     private readonly IAppSettingsService _appSettingsService;
     private readonly HttpClient _httpClient;
+    private bool _enableSlowModels = false; //todo: Implement this as a configurable option in the configuration panel
     private bool _enablePredefinedModels = true; //todo: Implement this as a configurable option in the configuration panel 
     private bool _enableCustomModels = true;  //todo: Implement this as a configurable option in the configuration panel 
 
     private readonly Dictionary<Uri, FileDownloader> _fileDownloads = new Dictionary<Uri, FileDownloader>();
 
     private delegate bool ModelDownloadingProgressCallback(string path, long? contentLength, long bytesRead);
-    public  event NotifyCollectionChangedEventHandler? SortedModelCollectionChanged;
+    public event NotifyCollectionChangedEventHandler? SortedModelCollectionChanged;
 
     private CancellationTokenSource? _cancellationTokenSource;
     private Task? _collectModelFilesTask;
@@ -351,7 +352,12 @@ private void CollectModels()
 
             foreach (var modelCard in predefinedModelCards)
             {
-                TryRegisterChatModel(modelCard, isSorted: true);
+                if (!_enableSlowModels && Graphics.DeviceConfiguration.GetPerformanceScore(modelCard) < 0.5)
+                {
+                    continue;
+                }
+
+                TryRegisterChatModel(modelCard, isSorted: true, rejectSlowModels: !_enableSlowModels);
 
                 _cancellationTokenSource!.Token.ThrowIfCancellationRequested();
             }
@@ -391,7 +397,7 @@ private void CollectModels()
         }
     }
 
-    private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted)
+    private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted, bool rejectSlowModels)
     {
         if (modelCard != null)
         {
@@ -402,6 +408,11 @@ private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted)
                 return false;
             }
 
+            if (rejectSlowModels && Graphics.DeviceConfiguration.GetPerformanceScore(modelCard) < 0.5)
+            {
+                return false;
+            }
+
             if (!ContainsModel(_models, modelCard, out _))
             {
                 _models.Add(modelCard);
@@ -430,7 +441,7 @@ private void HandleFile(string filePath)
             return;
         }
 
-        TryRegisterChatModel(modelCard, isSorted);
+        TryRegisterChatModel(modelCard, isSorted, rejectSlowModels: false);
     }
 
     private void HandleFileRecording(Uri fileUri)
diff --git a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
index 1a3b8ce..0d9eb78 100644
--- a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
+++ b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
@@ -198,7 +198,7 @@
                             <ColumnDefinition Width="0.5*" />
                             <ColumnDefinition Width="0.5*" />
                             <ColumnDefinition Width="0.5*" />
-                            <ColumnDefinition Width="0.5*" />
+                            <ColumnDefinition Width="0.9*" />
                             <ColumnDefinition Width="0.2*" />
                         </Grid.ColumnDefinitions>
 

From 32c5518c8deec36dd53273a318f36d82aaaad5a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Tue, 24 Dec 2024 13:51:08 +0100
Subject: [PATCH 4/9] LLMFileManager update

---
 LM-Kit-Maestro/Services/LLMFileManager.cs | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/LM-Kit-Maestro/Services/LLMFileManager.cs b/LM-Kit-Maestro/Services/LLMFileManager.cs
index b33c58f..365e3d2 100644
--- a/LM-Kit-Maestro/Services/LLMFileManager.cs
+++ b/LM-Kit-Maestro/Services/LLMFileManager.cs
@@ -352,11 +352,6 @@ private void CollectModels()
 
             foreach (var modelCard in predefinedModelCards)
             {
-                if (!_enableSlowModels && Graphics.DeviceConfiguration.GetPerformanceScore(modelCard) < 0.5)
-                {
-                    continue;
-                }
-
                 TryRegisterChatModel(modelCard, isSorted: true, rejectSlowModels: !_enableSlowModels);
 
                 _cancellationTokenSource!.Token.ThrowIfCancellationRequested();
@@ -408,7 +403,7 @@ private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted, bool reje
                 return false;
             }
 
-            if (rejectSlowModels && Graphics.DeviceConfiguration.GetPerformanceScore(modelCard) < 0.5)
+            if (rejectSlowModels && Graphics.DeviceConfiguration.GetPerformanceScore(modelCard) < 0.3)
             {
                 return false;
             }

From 6f8093b68da830e58c000353fbc46665574b42c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Wed, 25 Dec 2024 11:45:49 +0100
Subject: [PATCH 5/9] Adds option to display/hide slow-performing models

---
 .../Services/Interfaces/ILLMFileManager.cs    |  3 +-
 LM-Kit-Maestro/Services/LLMFileManager.cs     | 62 ++++++++++---------
 LM-Kit-Maestro/UI/Pages/ModelsPage.xaml       | 24 ++++++-
 .../ViewModels/ModelListViewModel.cs          | 22 +------
 4 files changed, 58 insertions(+), 53 deletions(-)

diff --git a/LM-Kit-Maestro/Services/Interfaces/ILLMFileManager.cs b/LM-Kit-Maestro/Services/Interfaces/ILLMFileManager.cs
index 7ef0390..94a0bd7 100644
--- a/LM-Kit-Maestro/Services/Interfaces/ILLMFileManager.cs
+++ b/LM-Kit-Maestro/Services/Interfaces/ILLMFileManager.cs
@@ -11,10 +11,9 @@ public interface ILLMFileManager
     ReadOnlyObservableCollection<ModelCard> UnsortedModels { get; }
     bool FileCollectingInProgress { get; }
     string ModelStorageDirectory { get; set; }
-
     long TotalModelSize { get; }
     int DownloadedCount { get; }
-
+    public bool EnableSlowModels { get; set; }
     event EventHandler? FileCollectingCompleted;
     void Initialize();
     void DeleteModel(ModelCard modelCard);
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.cs b/LM-Kit-Maestro/Services/LLMFileManager.cs
index 365e3d2..5400500 100644
--- a/LM-Kit-Maestro/Services/LLMFileManager.cs
+++ b/LM-Kit-Maestro/Services/LLMFileManager.cs
@@ -26,7 +26,6 @@ public partial class LLMFileManager : ObservableObject, ILLMFileManager
     private readonly FileSystemEntryRecorder _fileSystemEntryRecorder = new FileSystemEntryRecorder();
     private readonly IAppSettingsService _appSettingsService;
     private readonly HttpClient _httpClient;
-    private bool _enableSlowModels = false; //todo: Implement this as a configurable option in the configuration panel
     private bool _enablePredefinedModels = true; //todo: Implement this as a configurable option in the configuration panel 
     private bool _enableCustomModels = true;  //todo: Implement this as a configurable option in the configuration panel 
 
@@ -41,7 +40,6 @@ public partial class LLMFileManager : ObservableObject, ILLMFileManager
     public ReadOnlyObservableCollection<ModelCard> Models { get; }
     public ReadOnlyObservableCollection<ModelCard> UnsortedModels { get; }
 
-
     private ObservableCollection<ModelCard> _models { get; } = new ObservableCollection<ModelCard>();
     private ObservableCollection<ModelCard> _unsortedModels { get; } = new ObservableCollection<ModelCard>();
 
@@ -54,6 +52,13 @@ public partial class LLMFileManager : ObservableObject, ILLMFileManager
     [ObservableProperty]
     private bool _fileCollectingInProgress;
 
+    [ObservableProperty]
+    private bool _enableSlowModels = false;
+
+
+    private List<ModelCard> _predefinedModelCards = ModelCard.GetPredefinedModelCards();
+
+
     private string _modelStorageDirectory = string.Empty;
     public string ModelStorageDirectory
     {
@@ -344,15 +349,12 @@ private void TerminateFileCollectingOperation()
 
     private void CollectModels()
     {
-        List<ModelCard>? predefinedModelCards = null;
 
         if (_enablePredefinedModels)
         {
-            predefinedModelCards = ModelCard.GetPredefinedModelCards();
-
-            foreach (var modelCard in predefinedModelCards)
+            foreach (var modelCard in _predefinedModelCards)
             {
-                TryRegisterChatModel(modelCard, isSorted: true, rejectSlowModels: !_enableSlowModels);
+                TryRegisterChatModel(modelCard, isSorted: true);
 
                 _cancellationTokenSource!.Token.ThrowIfCancellationRequested();
             }
@@ -364,22 +366,19 @@ private void CollectModels()
 
             foreach (var filePath in files)
             {
-                if (predefinedModelCards != null)
+                bool processed = false;
+                foreach (var predefinedModel in _predefinedModelCards)
                 {
-                    bool processed = false;
-                    foreach (var predefinedModel in predefinedModelCards)
-                    {
-                        if (predefinedModel.LocalPath == filePath)
-                        {//Skip this model because it has already been processed
-                            processed = true;
-                            break;
-                        }
+                    if (predefinedModel.LocalPath == filePath)
+                    {//Skip this model because it has already been processed
+                        processed = true;
+                        break;
                     }
+                }
 
-                    if (processed)
-                    {
-                        continue;
-                    }
+                if (processed)
+                {
+                    continue;
                 }
 
                 if (ShouldCheckFile(filePath))
@@ -392,7 +391,7 @@ private void CollectModels()
         }
     }
 
-    private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted, bool rejectSlowModels)
+    private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted)
     {
         if (modelCard != null)
         {
@@ -403,13 +402,15 @@ private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted, bool reje
                 return false;
             }
 
-            if (rejectSlowModels && Graphics.DeviceConfiguration.GetPerformanceScore(modelCard) < 0.3)
-            {
-                return false;
-            }
+            bool isSlowModel = Graphics.DeviceConfiguration.GetPerformanceScore(modelCard) < 0.3;
 
             if (!ContainsModel(_models, modelCard, out _))
             {
+                if (isSlowModel && !EnableSlowModels)
+                {
+                    return false;
+                }
+
                 _models.Add(modelCard);
 
                 if (!isSorted)
@@ -419,9 +420,9 @@ private bool TryRegisterChatModel(ModelCard? modelCard, bool isSorted, bool reje
 
                 return true;
             }
-            else
+            else if (isSlowModel && !EnableSlowModels)
             {
-                //todo: Add feedback to indicate that a duplicate model has been identified
+                _models.Remove(modelCard);
             }
         }
 
@@ -436,7 +437,7 @@ private void HandleFile(string filePath)
             return;
         }
 
-        TryRegisterChatModel(modelCard, isSorted, rejectSlowModels: false);
+        TryRegisterChatModel(modelCard, isSorted);
     }
 
     private void HandleFileRecording(Uri fileUri)
@@ -574,6 +575,11 @@ private void OnModelDownloadingProgressed(string path, long? contentLength, long
     }
 #endif
 
+    partial void OnEnableSlowModelsChanged(bool value)
+    {
+        _ = CollectModelsAsync();
+    }
+
     private void OnModelCollectionChanged(object? sender, NotifyCollectionChangedEventArgs e)
     {
         if (e.Action == NotifyCollectionChangedAction.Add)
diff --git a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
index 0d9eb78..9c69b69 100644
--- a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
+++ b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
@@ -317,6 +317,8 @@
     </ui:PageBase.Resources>
 
     <ui:PageBase.Header>
+
+       
         <Grid 
             Padding="20, 0"
             ColumnSpacing="8">
@@ -411,9 +413,9 @@
                                 <Label.FormattedText>
                                     <FormattedString>
                                         <Span Text="You have "/>
-                                        <Span Text="{Binding ModelListViewModel.DownloadedCount}" FontAttributes="Bold"/>
+                                        <Span Text="{Binding FileManager.DownloadedCount}" FontAttributes="Bold"/>
                                         <Span Text=" downloaded model(s) taking a total of "/>
-                                        <Span Text="{Binding ModelListViewModel.TotalModelSize, Converter={converters:FileSizeConverter}}" FontAttributes="Bold"/>
+                                        <Span Text="{Binding FileManager.TotalModelSize, Converter={converters:FileSizeConverter}}" FontAttributes="Bold"/>
                                     </FormattedString>
                                 </Label.FormattedText>
                             </Label>
@@ -427,9 +429,25 @@
                             Command="{Binding Source={x:Reference modelsPage}, Path=ShowUnsortedModelFilesPopupCommand, x:DataType=ui:ModelsPage}"
                             IsVisible="{Binding FileManager.UnsortedModels.Count, Converter={converters:GreaterThanZeroConverter}}"/>
                         </Grid>
+
+                        <HorizontalStackLayout Margin="15,0" VerticalOptions="EndAndExpand" HorizontalOptions="Start">
+                            <CheckBox        
+                                Color="{StaticResource Primary}"
+                                BackgroundColor="Transparent"   
+                                IsChecked="{Binding Path=FileManager.EnableSlowModels, Mode=TwoWay}"
+                                VerticalOptions="Center"
+                                HorizontalOptions="Start" />
+                            <Label 
+                                Text="Display slow-performing models"
+                                VerticalOptions="Center"
+                                HorizontalOptions="Start"
+                                Margin="0,0,0,0" />
+                        </HorizontalStackLayout>
+
                     </VerticalStackLayout>
 
-                    <CollectionView Margin="0, 16, 0, 0" x:Name="modelsCollectionView" Grid.Row="1">
+
+                    <CollectionView Margin="0, 5, 0, 0" x:Name="modelsCollectionView" Grid.Row="1">
                         <CollectionView.ItemsLayout>
                             <LinearItemsLayout ItemSpacing="8" Orientation="Vertical"/>
                         </CollectionView.ItemsLayout>
diff --git a/LM-Kit-Maestro/ViewModels/ModelListViewModel.cs b/LM-Kit-Maestro/ViewModels/ModelListViewModel.cs
index fbcefea..0dc8235 100644
--- a/LM-Kit-Maestro/ViewModels/ModelListViewModel.cs
+++ b/LM-Kit-Maestro/ViewModels/ModelListViewModel.cs
@@ -20,12 +20,6 @@ public partial class ModelListViewModel : ViewModelBase
 
         public ObservableCollection<ModelInfoViewModel> Models { get; }
 
-        [ObservableProperty]
-        private long _totalModelSize;
-
-        [ObservableProperty]
-        private long _downloadedCount;
-
 
         [ObservableProperty]
         private double _loadingProgress;
@@ -34,7 +28,8 @@ public partial class ModelListViewModel : ViewModelBase
         private bool _modelLoadingIsFinishingUp;
 
         [ObservableProperty]
-        private bool _modelIsDownloading;
+        private bool _modelIsDownloading;
+
 
         private ModelInfoViewModel? _selectedModel;
         public ModelInfoViewModel? SelectedModel
@@ -55,7 +50,6 @@ public ModelInfoViewModel? SelectedModel
             }
         }
 
-
         public ModelListViewModel(IMainThread mainThread, ILLMFileManager fileManager, LMKitService lmKitService, IPopupService popupService,
             INavigationService navigationService, IPopupNavigation popupNavigation)
         {
@@ -72,18 +66,6 @@ public ModelListViewModel(IMainThread mainThread, ILLMFileManager fileManager, L
             LMKitService.ModelLoadingProgressed += OnModelLoadingProgressed;
             LMKitService.ModelLoadingFailed += OnModelLoadingFailed;
             LMKitService.ModelLoadingCompleted += OnModelLoadingCompleted;
-
-            _fileManager.PropertyChanged += (s, e) =>
-            {
-                if (e.PropertyName == nameof(_fileManager.TotalModelSize))
-                {
-                    TotalModelSize = _fileManager.TotalModelSize;
-                }
-                else if (e.PropertyName == nameof(_fileManager.DownloadedCount))
-                {
-                    DownloadedCount = _fileManager.DownloadedCount;
-                }
-            };
         }
 
         public void Initialize()

From c5df9445f043e44e36b90999bb4bfd1247d53fdd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Wed, 25 Dec 2024 12:32:20 +0100
Subject: [PATCH 6/9] EnableSlowModels persistency

---
 LM-Kit-Maestro/Services/AppSettingsService.cs |  15 +-
 .../Interfaces/IAppSettingsService.cs         |   1 +
 ...FileSystemEntryRecorder.DirectoryRecord.cs |  93 ++++++++++
 ...ager.FileSystemEntryRecorder.FileRecord.cs |  42 +++++
 ...Recorder.FileRecordPathChangedEventArgs.cs |  20 +++
 ...stemEntryRecorder.FileSystemEntryRecord.cs |  38 ++++
 .../LLMFileManager.FileSystemEntryRecorder.cs | 164 +----------------
 LM-Kit-Maestro/Services/LLMFileManager.cs     |   7 +-
 .../Services/LMKitDefaultSettings.cs          |   1 +
 .../Mirostat2SamplingSettingsViewModel.cs     |  65 +++++++
 .../RandomSamplingSettingsViewModel.cs        | 113 ++++++++++++
 .../ViewModels/SettingsViewModel.cs           | 168 ------------------
 12 files changed, 392 insertions(+), 335 deletions(-)
 create mode 100644 LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.DirectoryRecord.cs
 create mode 100644 LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecord.cs
 create mode 100644 LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecordPathChangedEventArgs.cs
 create mode 100644 LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileSystemEntryRecord.cs
 create mode 100644 LM-Kit-Maestro/ViewModels/Mirostat2SamplingSettingsViewModel.cs
 create mode 100644 LM-Kit-Maestro/ViewModels/RandomSamplingSettingsViewModel.cs

diff --git a/LM-Kit-Maestro/Services/AppSettingsService.cs b/LM-Kit-Maestro/Services/AppSettingsService.cs
index 3ac3c06..fa8fa96 100644
--- a/LM-Kit-Maestro/Services/AppSettingsService.cs
+++ b/LM-Kit-Maestro/Services/AppSettingsService.cs
@@ -40,7 +40,7 @@ public string ModelStorageDirectory
         {
             string directory = Settings.Get(nameof(ModelStorageDirectory), LMKitDefaultSettings.DefaultModelStorageDirectory);
 
-            if(directory != LMKit.Global.Configuration.ModelStorageDirectory)
+            if (directory != LMKit.Global.Configuration.ModelStorageDirectory)
             {
                 LMKit.Global.Configuration.ModelStorageDirectory = directory;
             }
@@ -55,6 +55,19 @@ public string ModelStorageDirectory
         }
     }
 
+    public bool EnableSlowModels
+    {
+        get
+        {
+            return Settings.Get(nameof(EnableSlowModels), LMKitDefaultSettings.DefaultEnableSlowModels);
+        }
+        set
+        {
+            Settings.Set(nameof(EnableSlowModels), value);
+            OnPropertyChanged();
+        }
+    }
+
     public string SystemPrompt
     {
         get
diff --git a/LM-Kit-Maestro/Services/Interfaces/IAppSettingsService.cs b/LM-Kit-Maestro/Services/Interfaces/IAppSettingsService.cs
index 45c46cb..60ff24d 100644
--- a/LM-Kit-Maestro/Services/Interfaces/IAppSettingsService.cs
+++ b/LM-Kit-Maestro/Services/Interfaces/IAppSettingsService.cs
@@ -11,4 +11,5 @@ public interface IAppSettingsService
     public SamplingMode SamplingMode { get; set; }
     public RandomSamplingConfig RandomSamplingConfig { get; set; }
     public Mirostat2SamplingConfig Mirostat2SamplingConfig { get; set; }
+    public bool EnableSlowModels { get; set; }
 }
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.DirectoryRecord.cs b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.DirectoryRecord.cs
new file mode 100644
index 0000000..ca46f1a
--- /dev/null
+++ b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.DirectoryRecord.cs
@@ -0,0 +1,93 @@
+namespace LMKit.Maestro.Services;
+
+public partial class LLMFileManager
+{
+    private sealed partial class FileSystemEntryRecorder
+    {
+        public class DirectoryRecord : FileSystemEntryRecord
+        {
+            public List<FileSystemEntryRecord> Entries { get; protected set; }
+
+            public DirectoryRecord(string name, DirectoryRecord? parent) : base(name, parent)
+            {
+                Entries = new List<FileSystemEntryRecord>();
+            }
+
+            public bool DeleteEntry(FileSystemEntryRecord entry)
+            {
+                return Entries.Remove(entry);
+            }
+
+            public void AddEntry(FileSystemEntryRecord entry)
+            {
+                Entries.Add(entry);
+            }
+
+            public DirectoryRecord? TryGetChildDirectory(string name)
+            {
+                foreach (var child in Entries)
+                {
+                    if (child is DirectoryRecord childDirectory && string.CompareOrdinal(child.Name, name) == 0)
+                    {
+                        return childDirectory;
+                    }
+                }
+
+                return null;
+            }
+
+            public FileRecord? TryGetChildFile(string name)
+            {
+                foreach (var child in Entries)
+                {
+                    if (child is FileRecord childFile && string.CompareOrdinal(childFile.Name, name) == 0)
+                    {
+                        return childFile;
+                    }
+                }
+
+                return null;
+            }
+
+            public FileSystemEntryRecord? TryGetChildEntry(string name)
+            {
+                foreach (var entry in Entries)
+                {
+                    if (string.CompareOrdinal(entry.Name, name) == 0)
+                    {
+                        return entry;
+                    }
+                }
+
+                return null;
+            }
+
+            protected override void OnEntryRenamed()
+            {
+                PropagateRenamedParentEntryToChildren(1, Name, this);
+            }
+
+            private void PropagateRenamedParentEntryToChildren(int ancestorLevel, string newName, DirectoryRecord directoryRecord)
+            {
+                foreach (var child in directoryRecord.Entries)
+                {
+                    if (child is FileRecord childFile)
+                    {
+                        childFile.OnParentDirectoryRenamed(ancestorLevel, newName);
+                    }
+                    else if (child is DirectoryRecord childDirectory)
+                    {
+                        PropagateRenamedParentEntryToChildren(ancestorLevel + 1, newName, childDirectory);
+                    }
+                }
+            }
+
+#if DEBUG
+            public override string ToString()
+            {
+                return ("(directory)" + Name);
+            }
+#endif
+        }
+    }
+}
\ No newline at end of file
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecord.cs b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecord.cs
new file mode 100644
index 0000000..9f55f0f
--- /dev/null
+++ b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecord.cs
@@ -0,0 +1,42 @@
+using LMKit.Maestro.Helpers;
+
+namespace LMKit.Maestro.Services;
+
+public partial class LLMFileManager
+{
+    private sealed partial class FileSystemEntryRecorder
+    {
+        public class FileRecord : FileSystemEntryRecord
+        {
+            public Uri FileUri { get; set; }
+
+            public event EventHandler? FilePathChanged;
+
+            public FileRecord(Uri fileUri, string name, DirectoryRecord parent) : base(name, parent)
+            {
+                FileUri = fileUri;
+            }
+
+            public void OnParentDirectoryRenamed(int ancestorLevel, string newName)
+            {
+                Uri oldUri = FileUri;
+                FileUri = FileHelpers.GetRenamedFileUri(FileUri, newName, ancestorLevel);
+                FilePathChanged?.Invoke(this, new FileRecordPathChangedEventArgs(oldUri, FileUri));
+            }
+
+            protected override void OnEntryRenamed()
+            {
+                Uri oldUri = FileUri;
+                FileUri = FileHelpers.GetRenamedFileUri(FileUri, Name);
+                FilePathChanged?.Invoke(this, new FileRecordPathChangedEventArgs(oldUri, FileUri));
+            }
+
+#if DEBUG
+            public override string ToString()
+            {
+                return ("(file)" + Name);
+            }
+#endif
+        }
+    }
+}
\ No newline at end of file
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecordPathChangedEventArgs.cs b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecordPathChangedEventArgs.cs
new file mode 100644
index 0000000..fc121a1
--- /dev/null
+++ b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileRecordPathChangedEventArgs.cs
@@ -0,0 +1,20 @@
+namespace LMKit.Maestro.Services;
+
+public partial class LLMFileManager
+{
+    private sealed partial class FileSystemEntryRecorder
+    {
+        public sealed class FileRecordPathChangedEventArgs : EventArgs
+        {
+            public Uri OldPath { get;  }
+
+            public Uri NewPath { get;  }
+
+            public FileRecordPathChangedEventArgs(Uri oldPath, Uri newPath)
+            {
+                OldPath = oldPath;
+                NewPath = newPath;
+            }
+        }
+    }
+}
\ No newline at end of file
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileSystemEntryRecord.cs b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileSystemEntryRecord.cs
new file mode 100644
index 0000000..8214d90
--- /dev/null
+++ b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.FileSystemEntryRecord.cs
@@ -0,0 +1,38 @@
+namespace LMKit.Maestro.Services;
+
+public partial class LLMFileManager
+{
+    private sealed partial class FileSystemEntryRecorder
+    {
+        public abstract class FileSystemEntryRecord
+        {
+            public DirectoryRecord? Parent { get; protected set; }
+
+            public string Name { get; private set; }
+
+            public FileSystemEntryRecord(string name, DirectoryRecord? parent)
+            {
+                Name = name;
+                Parent = parent;
+            }
+
+            protected abstract void OnEntryRenamed();
+
+            public void Rename(string name)
+            {
+                Name = name;
+                OnEntryRenamed();
+            }
+
+            public bool Delete()
+            {
+                if (Parent == null)
+                {
+                    return false;
+                }
+
+                return Parent.DeleteEntry(this);
+            }
+        }
+    }
+}
\ No newline at end of file
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs
index 76e041e..2484ce1 100644
--- a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs
+++ b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs
@@ -5,7 +5,7 @@ namespace LMKit.Maestro.Services;
 
 public partial class LLMFileManager
 {
-    private sealed class FileSystemEntryRecorder
+    private sealed partial class FileSystemEntryRecorder
     {
         private DirectoryRecord? _rootDirectoryRecord;
         private Uri? _rootDirectoryUri;
@@ -156,169 +156,7 @@ private void DumpRecords(DirectoryRecord directory, int level = 0)
                 }
             }
         }
-#endif
-
-        public abstract class FileSystemEntryRecord
-        {
-            public DirectoryRecord? Parent { get; protected set; }
-
-            public string Name { get; private set; }
-
-            public FileSystemEntryRecord(string name, DirectoryRecord? parent)
-            {
-                Name = name;
-                Parent = parent;
-            }
 
-            protected abstract void OnEntryRenamed();
-
-            public void Rename(string name)
-            {
-                Name = name;
-                OnEntryRenamed();
-            }
-
-            public bool Delete()
-            {
-                if (Parent == null)
-                {
-                    return false;
-                }
-
-                return Parent.DeleteEntry(this);
-            }
-        }
-
-        public class FileRecord : FileSystemEntryRecord
-        {
-            public Uri FileUri { get; set; }
-
-            public event EventHandler? FilePathChanged;
-
-            public FileRecord(Uri fileUri, string name, DirectoryRecord parent) : base(name, parent)
-            {
-                FileUri = fileUri;
-            }
-
-            public void OnParentDirectoryRenamed(int ancestorLevel, string newName)
-            {
-                Uri oldUri = FileUri;
-                FileUri = FileHelpers.GetRenamedFileUri(FileUri, newName, ancestorLevel);
-                FilePathChanged?.Invoke(this, new FileRecordPathChangedEventArgs(oldUri, FileUri));
-            }
-
-            protected override void OnEntryRenamed()
-            {
-                Uri oldUri = FileUri;
-                FileUri = FileHelpers.GetRenamedFileUri(FileUri, Name);
-                FilePathChanged?.Invoke(this, new FileRecordPathChangedEventArgs(oldUri, FileUri));
-            }
-
-#if DEBUG
-            public override string ToString()
-            {
-                return ("(file)" + Name);
-            }
 #endif
-        }
-
-        public class DirectoryRecord : FileSystemEntryRecord
-        {
-            public List<FileSystemEntryRecord> Entries { get; protected set; }
-
-            public DirectoryRecord(string name, DirectoryRecord? parent) : base(name, parent)
-            {
-                Entries = new List<FileSystemEntryRecord>();
-            }
-
-            public bool DeleteEntry(FileSystemEntryRecord entry)
-            {
-                return Entries.Remove(entry);
-            }
-
-            public void AddEntry(FileSystemEntryRecord entry)
-            {
-                Entries.Add(entry);
-            }
-
-            public DirectoryRecord? TryGetChildDirectory(string name)
-            {
-                foreach (var child in Entries)
-                {
-                    if (child is DirectoryRecord childDirectory && string.CompareOrdinal(child.Name, name) == 0)
-                    {
-                        return childDirectory;
-                    }
-                }
-
-                return null;
-            }
-
-            public FileRecord? TryGetChildFile(string name)
-            {
-                foreach (var child in Entries)
-                {
-                    if (child is FileRecord childFile && string.CompareOrdinal(childFile.Name, name) == 0)
-                    {
-                        return childFile;
-                    }
-                }
-
-                return null;
-            }
-
-            public FileSystemEntryRecord? TryGetChildEntry(string name)
-            {
-                foreach (var entry in Entries)
-                {
-                    if (string.CompareOrdinal(entry.Name, name) == 0)
-                    {
-                        return entry;
-                    }
-                }
-
-                return null;
-            }
-
-            protected override void OnEntryRenamed()
-            {
-                PropagateRenamedParentEntryToChildren(1, Name, this);
-            }
-
-            private void PropagateRenamedParentEntryToChildren(int ancestorLevel, string newName, DirectoryRecord directoryRecord)
-            {
-                foreach (var child in directoryRecord.Entries)
-                {
-                    if (child is FileRecord childFile)
-                    {
-                        childFile.OnParentDirectoryRenamed(ancestorLevel, newName);
-                    }
-                    else if (child is DirectoryRecord childDirectory)
-                    {
-                        PropagateRenamedParentEntryToChildren(ancestorLevel + 1, newName, childDirectory);
-                    }
-                }
-            }
-
-#if DEBUG
-            public override string ToString()
-            {
-                return ("(directory)" + Name);
-            }
-#endif
-        }
-
-        public sealed class FileRecordPathChangedEventArgs : EventArgs
-        {
-            public Uri OldPath { get;  }
-
-            public Uri NewPath { get;  }
-
-            public FileRecordPathChangedEventArgs(Uri oldPath, Uri newPath)
-            {
-                OldPath = oldPath;
-                NewPath = newPath;
-            }
-        }
     }
 }
\ No newline at end of file
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.cs b/LM-Kit-Maestro/Services/LLMFileManager.cs
index 5400500..fa3fbf3 100644
--- a/LM-Kit-Maestro/Services/LLMFileManager.cs
+++ b/LM-Kit-Maestro/Services/LLMFileManager.cs
@@ -53,7 +53,7 @@ public partial class LLMFileManager : ObservableObject, ILLMFileManager
     private bool _fileCollectingInProgress;
 
     [ObservableProperty]
-    private bool _enableSlowModels = false;
+    private bool _enableSlowModels;
 
 
     private List<ModelCard> _predefinedModelCards = ModelCard.GetPredefinedModelCards();
@@ -95,8 +95,8 @@ public LLMFileManager(IAppSettingsService appSettingsService, HttpClient httpCli
         Models = new ReadOnlyObservableCollection<ModelCard>(_models);
         UnsortedModels = new ReadOnlyObservableCollection<ModelCard>(_unsortedModels);
         _appSettingsService = appSettingsService;
-        _httpClient = httpClient;
 
+        _httpClient = httpClient;
         _models.CollectionChanged += OnModelCollectionChanged;
         _unsortedModels.CollectionChanged += OnUnsortedModelCollectionChanged;
 
@@ -118,8 +118,8 @@ public void Initialize()
             // todo
         }
 
+        _enableSlowModels = _appSettingsService.EnableSlowModels;
         ModelStorageDirectory = _appSettingsService.ModelStorageDirectory;
-
 #if WINDOWS
         _fileSystemWatcher.Changed += OnFileChanged;
         _fileSystemWatcher.Deleted += OnFileDeleted;
@@ -577,6 +577,7 @@ private void OnModelDownloadingProgressed(string path, long? contentLength, long
 
     partial void OnEnableSlowModelsChanged(bool value)
     {
+        _appSettingsService.EnableSlowModels = value;
         _ = CollectModelsAsync();
     }
 
diff --git a/LM-Kit-Maestro/Services/LMKitDefaultSettings.cs b/LM-Kit-Maestro/Services/LMKitDefaultSettings.cs
index 39b0198..91d8cf4 100644
--- a/LM-Kit-Maestro/Services/LMKitDefaultSettings.cs
+++ b/LM-Kit-Maestro/Services/LMKitDefaultSettings.cs
@@ -9,6 +9,7 @@ public static class LMKitDefaultSettings
     public static readonly int DefaultContextSize = Graphics.DeviceConfiguration.GetOptimalContextSize();
     public const int DefaultRequestTimeout = 120;
     public const SamplingMode DefaultSamplingMode = SamplingMode.Random;
+    public const bool DefaultEnableSlowModels = false;
 
     public static SamplingMode[] AvailableSamplingModes { get; } = (SamplingMode[])Enum.GetValues(typeof(SamplingMode));
 
diff --git a/LM-Kit-Maestro/ViewModels/Mirostat2SamplingSettingsViewModel.cs b/LM-Kit-Maestro/ViewModels/Mirostat2SamplingSettingsViewModel.cs
new file mode 100644
index 0000000..bb57714
--- /dev/null
+++ b/LM-Kit-Maestro/ViewModels/Mirostat2SamplingSettingsViewModel.cs
@@ -0,0 +1,65 @@
+using CommunityToolkit.Mvvm.ComponentModel;
+using LMKit.Maestro.Services;
+
+namespace LMKit.Maestro.ViewModels
+{
+    public partial class Mirostat2SamplingSettingsViewModel : ObservableObject
+    {
+        private readonly Mirostat2SamplingConfig _config;
+
+        public float Temperature
+        {
+            get => _config.Temperature;
+            set
+            {
+                float newValue = (float)Math.Round(value, 2);
+
+                if (newValue != _config.Temperature)
+                {
+                    _config.Temperature = newValue;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public float TargetEntropy
+        {
+            get => _config.TargetEntropy;
+            set
+            {
+                if (_config.TargetEntropy != value)
+                {
+                    _config.TargetEntropy = value;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public float LearningRate
+        {
+            get => _config.LearningRate;
+            set
+            {
+                float newValue = (float)Math.Round(value, 2);
+
+                if (newValue != _config.LearningRate)
+                {
+                    _config.LearningRate = newValue;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public Mirostat2SamplingSettingsViewModel(Mirostat2SamplingConfig Mirostat2SamplingConfig)
+        {
+            _config = Mirostat2SamplingConfig;
+        }
+
+        public void Reset()
+        {
+            Temperature = LMKitDefaultSettings.DefaultMirostat2SamplingTemperature;
+            TargetEntropy = LMKitDefaultSettings.DefaultMirostat2SamplingTargetEntropy;
+            LearningRate = LMKitDefaultSettings.DefaultMirostat2SamplingLearningRate;
+        }
+    }
+}
diff --git a/LM-Kit-Maestro/ViewModels/RandomSamplingSettingsViewModel.cs b/LM-Kit-Maestro/ViewModels/RandomSamplingSettingsViewModel.cs
new file mode 100644
index 0000000..a0c095a
--- /dev/null
+++ b/LM-Kit-Maestro/ViewModels/RandomSamplingSettingsViewModel.cs
@@ -0,0 +1,113 @@
+using CommunityToolkit.Mvvm.ComponentModel;
+using LMKit.Maestro.Services;
+
+namespace LMKit.Maestro.ViewModels
+{
+    public partial class RandomSamplingSettingsViewModel : ObservableObject
+    {
+        private readonly RandomSamplingConfig _config;
+
+        public float Temperature
+        {
+            get => _config.Temperature;
+            set
+            {
+                float newValue = (float)Math.Round(value, 2);
+
+                if (newValue != _config.Temperature)
+                {
+                    _config.Temperature = newValue;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public float DynamicTemperatureRange
+        {
+            get => _config.DynamicTemperatureRange;
+            set
+            {
+                float newValue = (float)Math.Round(value, 2);
+
+                if (newValue != _config.DynamicTemperatureRange)
+                {
+                    _config.DynamicTemperatureRange = newValue;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public float TopP
+        {
+            get => _config.TopP;
+            set
+            {
+                float newValue = (float)Math.Round(value, 2);
+
+                if (newValue != _config.TopP)
+                {
+                    _config.TopP = newValue;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public float MinP
+        {
+            get => _config.MinP;
+            set
+            {
+                float newValue = (float)Math.Round(value, 2);
+
+                if (newValue != _config.MinP)
+                {
+                    _config.MinP = newValue;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public int TopK
+        {
+            get => _config.TopK;
+            set
+            {
+                if (_config.TopK != value)
+                {
+                    _config.TopK = value;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public float LocallyTypical
+        {
+            get => _config.LocallyTypical;
+            set
+            {
+                float newValue = (float)Math.Round(value, 2);
+
+                if (newValue != _config.LocallyTypical)
+                {
+                    _config.LocallyTypical = newValue;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
+        public RandomSamplingSettingsViewModel(RandomSamplingConfig randomSamplingConfig)
+        {
+            _config = randomSamplingConfig;
+        }
+
+        public void Reset()
+        {
+            Temperature = LMKitDefaultSettings.DefaultRandomSamplingTemperature;
+            DynamicTemperatureRange = LMKitDefaultSettings.DefaultRandomSamplingDynamicTemperatureRange;
+            TopP = LMKitDefaultSettings.DefaultRandomSamplingTopP;
+            MinP = LMKitDefaultSettings.DefaultRandomSamplingMinP;
+            TopK = LMKitDefaultSettings.DefaultRandomSamplingTopK;
+            LocallyTypical = LMKitDefaultSettings.DefaultRandomSamplingLocallyTypical;
+        }
+    }
+}
diff --git a/LM-Kit-Maestro/ViewModels/SettingsViewModel.cs b/LM-Kit-Maestro/ViewModels/SettingsViewModel.cs
index a0ec2ba..1550392 100644
--- a/LM-Kit-Maestro/ViewModels/SettingsViewModel.cs
+++ b/LM-Kit-Maestro/ViewModels/SettingsViewModel.cs
@@ -137,172 +137,4 @@ public void Save()
             _appSettingsService.Mirostat2SamplingConfig = _config.Mirostat2SamplingConfig;
         }
     }
-
-    public partial class RandomSamplingSettingsViewModel : ObservableObject
-    {
-        private readonly RandomSamplingConfig _config;
-
-        public float Temperature
-        {
-            get => _config.Temperature;
-            set
-            {
-                float newValue = (float)Math.Round(value, 2);
-
-                if (newValue != _config.Temperature)
-                {
-                    _config.Temperature = newValue;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public float DynamicTemperatureRange
-        {
-            get => _config.DynamicTemperatureRange;
-            set
-            {
-                float newValue = (float)Math.Round(value, 2);
-
-                if (newValue != _config.DynamicTemperatureRange)
-                {
-                    _config.DynamicTemperatureRange = newValue;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public float TopP
-        {
-            get => _config.TopP;
-            set
-            {
-                float newValue = (float)Math.Round(value, 2);
-
-                if (newValue != _config.TopP)
-                {
-                    _config.TopP = newValue;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public float MinP
-        {
-            get => _config.MinP;
-            set
-            {
-                float newValue = (float)Math.Round(value, 2);
-
-                if (newValue != _config.MinP)
-                {
-                    _config.MinP = newValue;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public int TopK
-        {
-            get => _config.TopK;
-            set
-            {
-                if (_config.TopK != value)
-                {
-                    _config.TopK = value;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public float LocallyTypical
-        {
-            get => _config.LocallyTypical;
-            set
-            {
-                float newValue = (float)Math.Round(value, 2);
-
-                if (newValue != _config.LocallyTypical)
-                {
-                    _config.LocallyTypical = newValue;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public RandomSamplingSettingsViewModel(RandomSamplingConfig randomSamplingConfig)
-        {
-            _config = randomSamplingConfig;
-        }
-
-        public void Reset()
-        {
-            Temperature = LMKitDefaultSettings.DefaultRandomSamplingTemperature;
-            DynamicTemperatureRange = LMKitDefaultSettings.DefaultRandomSamplingDynamicTemperatureRange;
-            TopP = LMKitDefaultSettings.DefaultRandomSamplingTopP;
-            MinP = LMKitDefaultSettings.DefaultRandomSamplingMinP;
-            TopK = LMKitDefaultSettings.DefaultRandomSamplingTopK;
-            LocallyTypical = LMKitDefaultSettings.DefaultRandomSamplingLocallyTypical;
-        }
-    }
-
-    public partial class Mirostat2SamplingSettingsViewModel : ObservableObject
-    {
-        private readonly Mirostat2SamplingConfig _config;
-
-        public float Temperature
-        {
-            get => _config.Temperature;
-            set
-            {
-                float newValue = (float)Math.Round(value, 2);
-
-                if (newValue != _config.Temperature)
-                {
-                    _config.Temperature = newValue;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public float TargetEntropy
-        {
-            get => _config.TargetEntropy;
-            set
-            {
-                if (_config.TargetEntropy != value)
-                {
-                    _config.TargetEntropy = value;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public float LearningRate
-        {
-            get => _config.LearningRate;
-            set
-            {
-                float newValue = (float)Math.Round(value, 2);
-
-                if (newValue != _config.LearningRate)
-                {
-                    _config.LearningRate = newValue;
-                    OnPropertyChanged();
-                }
-            }
-        }
-
-        public Mirostat2SamplingSettingsViewModel(Mirostat2SamplingConfig Mirostat2SamplingConfig)
-        {
-            _config = Mirostat2SamplingConfig;
-        }
-
-        public void Reset()
-        {
-            Temperature = LMKitDefaultSettings.DefaultMirostat2SamplingTemperature;
-            TargetEntropy = LMKitDefaultSettings.DefaultMirostat2SamplingTargetEntropy;
-            LearningRate = LMKitDefaultSettings.DefaultMirostat2SamplingLearningRate;
-        }
-    }
 }

From 3f58400b38a07e5e8ec4666206b7623c905b6214 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Wed, 25 Dec 2024 12:54:03 +0100
Subject: [PATCH 7/9] refactoring

---
 .../LLMFileManager.FileSystemEntryRecorder.cs | 18 ++++++++---
 LM-Kit-Maestro/Services/LLMFileManager.cs     | 31 ++++++++++++-------
 2 files changed, 33 insertions(+), 16 deletions(-)

diff --git a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs
index 2484ce1..76d7157 100644
--- a/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs
+++ b/LM-Kit-Maestro/Services/LLMFileManager.FileSystemEntryRecorder.cs
@@ -8,17 +8,27 @@ public partial class LLMFileManager
     private sealed partial class FileSystemEntryRecorder
     {
         private DirectoryRecord? _rootDirectoryRecord;
-        private Uri? _rootDirectoryUri;
+        private Uri _rootDirectoryUri;
 
-        public void Init(string rootDirectoryPath)
+        public FileSystemEntryRecorder(Uri rootDirectoryUri)
+        {
+            Update(rootDirectoryUri);
+        }
+
+        public void Update(Uri rootDirectoryUri)
         {
+            if ((rootDirectoryUri == _rootDirectoryUri))
+            {
+                return;
+            }
+
             if (_rootDirectoryRecord != null)
             {
                 Clear();
             }
 
-            _rootDirectoryUri = new Uri(rootDirectoryPath);
-            _rootDirectoryRecord = new DirectoryRecord(rootDirectoryPath, null);
+            _rootDirectoryUri = rootDirectoryUri;
+            _rootDirectoryRecord = new DirectoryRecord(rootDirectoryUri.LocalPath, null);
         }
 
         public void Clear()
diff --git a/LM-Kit-Maestro/Services/LLMFileManager.cs b/LM-Kit-Maestro/Services/LLMFileManager.cs
index fa3fbf3..189d6d0 100644
--- a/LM-Kit-Maestro/Services/LLMFileManager.cs
+++ b/LM-Kit-Maestro/Services/LLMFileManager.cs
@@ -23,11 +23,12 @@ public partial class LLMFileManager : ObservableObject, ILLMFileManager
     private static int InstanceCount = 0;
 #endif
 
-    private readonly FileSystemEntryRecorder _fileSystemEntryRecorder = new FileSystemEntryRecorder();
+    private readonly FileSystemEntryRecorder _fileSystemEntryRecorder;
     private readonly IAppSettingsService _appSettingsService;
     private readonly HttpClient _httpClient;
     private bool _enablePredefinedModels = true; //todo: Implement this as a configurable option in the configuration panel 
     private bool _enableCustomModels = true;  //todo: Implement this as a configurable option in the configuration panel 
+    private bool _isLoaded = false;
 
     private readonly Dictionary<Uri, FileDownloader> _fileDownloads = new Dictionary<Uri, FileDownloader>();
 
@@ -89,13 +90,13 @@ public LLMFileManager(IAppSettingsService appSettingsService, HttpClient httpCli
         {
             throw new InvalidProgramException("Invalid operation: Only one instance of this class should be created, and it must be instantiated through dependency injection.");
         }
+
         InstanceCount++;
 #endif
-
         Models = new ReadOnlyObservableCollection<ModelCard>(_models);
         UnsortedModels = new ReadOnlyObservableCollection<ModelCard>(_unsortedModels);
         _appSettingsService = appSettingsService;
-
+        _enableSlowModels = _appSettingsService.EnableSlowModels;
         _httpClient = httpClient;
         _models.CollectionChanged += OnModelCollectionChanged;
         _unsortedModels.CollectionChanged += OnUnsortedModelCollectionChanged;
@@ -104,22 +105,23 @@ public LLMFileManager(IAppSettingsService appSettingsService, HttpClient httpCli
         {
             notifyPropertyChanged.PropertyChanged += OnAppSettingsServicePropertyChanged;
         }
-    }
 
-    public void Initialize()
-    {
         try
         {
             EnsureModelDirectoryExists();
-
         }
         catch (Exception)
         {
             // todo
         }
 
-        _enableSlowModels = _appSettingsService.EnableSlowModels;
         ModelStorageDirectory = _appSettingsService.ModelStorageDirectory;
+        _fileSystemEntryRecorder = new FileSystemEntryRecorder(new Uri(ModelStorageDirectory));
+        _isLoaded = true;
+    }
+
+    public void Initialize()
+    {
 #if WINDOWS
         _fileSystemWatcher.Changed += OnFileChanged;
         _fileSystemWatcher.Deleted += OnFileDeleted;
@@ -129,6 +131,8 @@ public void Initialize()
         _fileSystemWatcher.IncludeSubdirectories = true;
         _fileSystemWatcher.EnableRaisingEvents = true;
 #endif
+
+        _ = CollectModelsAsync();
     }
 
 #if BETA_DOWNLOAD_MODELS
@@ -469,12 +473,15 @@ private async void OnModelStorageDirectoryChanged()
             _cancellationTokenSource?.Cancel();
         }
 
-        _fileSystemEntryRecorder.Init(_modelStorageDirectory);
+        if (_isLoaded)
+        {
+            _fileSystemEntryRecorder.Update(new Uri(_modelStorageDirectory));
 
-        _unsortedModels.Clear();
-        _models.Clear();
+            _unsortedModels.Clear();
+            _models.Clear();
 
-        await CollectModelsAsync();
+            await CollectModelsAsync();
+        }
     }
 
     private void OnAppSettingsServicePropertyChanged(object? sender, PropertyChangedEventArgs e)

From ae0b67dce67de632fb59ceed0f879c4f523b6ba4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Wed, 25 Dec 2024 13:22:26 +0100
Subject: [PATCH 8/9] moved some string consts to TooltipLabels

---
 LM-Kit-Maestro/UI/{TooltipLabels.cs => Localization.cs} | 6 +++++-
 LM-Kit-Maestro/UI/Pages/ModelsPage.xaml                 | 8 +++++---
 2 files changed, 10 insertions(+), 4 deletions(-)
 rename LM-Kit-Maestro/UI/{TooltipLabels.cs => Localization.cs} (78%)

diff --git a/LM-Kit-Maestro/UI/TooltipLabels.cs b/LM-Kit-Maestro/UI/Localization.cs
similarity index 78%
rename from LM-Kit-Maestro/UI/TooltipLabels.cs
rename to LM-Kit-Maestro/UI/Localization.cs
index 1c28cda..9d847ef 100644
--- a/LM-Kit-Maestro/UI/TooltipLabels.cs
+++ b/LM-Kit-Maestro/UI/Localization.cs
@@ -1,7 +1,8 @@
 namespace LMKit.Maestro.UI
 {
-    internal static class TooltipLabels
+    internal static class TooltipLabels //todo: rename to Locales.
     {
+        //todo: Implement support for multiple languages, including translation management and locale detection.
         public const string RegenerateResponse = "Regenerate response";
         public const string PreviousGeneratedResponse = "Previous generated response";
         public const string NextGeneratedResponse = "Next generated response";
@@ -27,5 +28,8 @@ internal static class TooltipLabels
         public const string ChatModelOptimized = "This model is optimized for conversational tasks";
         public const string MathModelOptimized = "This model is optimized for solving mathematical problems";
         public const string DeleteLocalModel = "Delete the model file from local storage";
+        public const string DisplaySlowPerformingModels = "Display slow-performing models";
+        public const string NoModelYetAvailable = "It looks like you don't have any model yet.";
+        public const string ModelFilesWillAppearHere = "Model files added to your model folder will appear here.";
     }
 }
\ No newline at end of file
diff --git a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
index 9c69b69..5f34f21 100644
--- a/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
+++ b/LM-Kit-Maestro/UI/Pages/ModelsPage.xaml
@@ -438,7 +438,7 @@
                                 VerticalOptions="Center"
                                 HorizontalOptions="Start" />
                             <Label 
-                                Text="Display slow-performing models"
+                                Text="{x:Static ui:TooltipLabels.DisplaySlowPerformingModels}"
                                 VerticalOptions="Center"
                                 HorizontalOptions="Start"
                                 Margin="0,0,0,0" />
@@ -463,8 +463,10 @@
                                 <Setter Property="EmptyView">
                                     <Setter.Value>
                                         <VerticalStackLayout VerticalOptions="End" HorizontalOptions="Center" Spacing="8">
-                                            <Label HorizontalTextAlignment="Center" Text="It looks like you don't have any model yet."/>
-                                            <Label HorizontalTextAlignment="Center" Text="Model files added to your model folder will appear here."/>
+                                            <Label HorizontalTextAlignment="Center"
+                                                   Text="{x:Static ui:TooltipLabels.NoModelYetAvailable}"/>
+                                            <Label HorizontalTextAlignment="Center" 
+                                                   Text="{x:Static ui:TooltipLabels.ModelFilesWillAppearHere}"/>
                                         </VerticalStackLayout>
 
                                     </Setter.Value>

From d769b2943f629a94d13885b77fd9b33894133365 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Carr=C3=A8re?= <loic.carrere@gmail.com>
Date: Wed, 25 Dec 2024 13:27:24 +0100
Subject: [PATCH 9/9] UT update

---
 tests/Services/DummyLLmFileManager.cs | 77 ++++++++++++++++++++++++++-
 1 file changed, 75 insertions(+), 2 deletions(-)

diff --git a/tests/Services/DummyLLmFileManager.cs b/tests/Services/DummyLLmFileManager.cs
index c3c84af..98650b8 100644
--- a/tests/Services/DummyLLmFileManager.cs
+++ b/tests/Services/DummyLLmFileManager.cs
@@ -20,14 +20,67 @@ public DummyLLmFileManager()
     {
         Models = new ReadOnlyObservableCollection<ModelCard>(_models);
         UnsortedModels = new ReadOnlyObservableCollection<ModelCard>(_unsortedModels);
-    }
-
+    }
+
+    event EventHandler? ILLMFileManager.FileCollectingCompleted
+    {
+        add
+        {
+            throw new NotImplementedException();
+        }
+
+        remove
+        {
+            throw new NotImplementedException();
+        }
+    }
+
+    event PropertyChangedEventHandler ILLMFileManager.PropertyChanged
+    {
+        add
+        {
+            throw new NotImplementedException();
+        }
+
+        remove
+        {
+            throw new NotImplementedException();
+        }
+    }
+
+    event NotifyCollectionChangedEventHandler? ILLMFileManager.SortedModelCollectionChanged
+    {
+        add
+        {
+            throw new NotImplementedException();
+        }
+
+        remove
+        {
+            throw new NotImplementedException();
+        }
+    }
+
     public bool FileCollectingInProgress { get; private set; }
     
     public string ModelStorageDirectory { get; set; }
     public long TotalModelSize { get; set; }
     public int DownloadedCount { get; set; }
 
+    ReadOnlyObservableCollection<ModelCard> ILLMFileManager.Models => throw new NotImplementedException();
+
+    ReadOnlyObservableCollection<ModelCard> ILLMFileManager.UnsortedModels => throw new NotImplementedException();
+
+    bool ILLMFileManager.FileCollectingInProgress => throw new NotImplementedException();
+
+    string ILLMFileManager.ModelStorageDirectory { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
+
+    long ILLMFileManager.TotalModelSize => throw new NotImplementedException();
+
+    int ILLMFileManager.DownloadedCount => throw new NotImplementedException();
+
+    bool ILLMFileManager.EnableSlowModels { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
+
 
 #pragma warning disable 67
     public event EventHandler? FileCollectingCompleted;
@@ -52,4 +105,24 @@ public bool IsPredefinedModel(ModelCard modelCard)
     public void OnModelDownloaded(ModelCard modelInfo)
     {
     }
+
+    void ILLMFileManager.Initialize()
+    {
+        throw new NotImplementedException();
+    }
+
+    void ILLMFileManager.DeleteModel(ModelCard modelCard)
+    {
+        throw new NotImplementedException();
+    }
+
+    bool ILLMFileManager.IsPredefinedModel(ModelCard modelCard)
+    {
+        throw new NotImplementedException();
+    }
+
+    void ILLMFileManager.OnModelDownloaded(ModelCard modelInfo)
+    {
+        throw new NotImplementedException();
+    }
 }