Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor calibrate.register to use reproject #112

Open
nabobalis opened this issue Mar 12, 2022 · 0 comments · May be fixed by #317
Open

Refactor calibrate.register to use reproject #112

nabobalis opened this issue Mar 12, 2022 · 0 comments · May be fixed by #317
Labels
aiaprep Feature Request New feature wanted!

Comments

@nabobalis
Copy link
Contributor

In GitLab by @wtbarnes on Mar 12, 2022, 10:54

Currently, register (which mimics the usual aiaprep workflow) using sunpy.map.GenericMap.rotate to rotate, scale, and translate the image.
Instead, we should just use reproject to reproject the level 1 image into a WCS which has the desired scale (specified using CDELT) and orientation (specified using the PC matrix) and puts the center of the sun at the center of the pixel grid (in the case of a full-disk image).

This would also resolve #112.
@wtbarnes wtbarnes linked a pull request Nov 1, 2023 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aiaprep Feature Request New feature wanted!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use reproject for image registration wtbarnes/aiapy
1 participant
@nabobalis