Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculate_orbital_wavelength_variation is very broken #3

Open
nabobalis opened this issue May 22, 2020 · 0 comments
Open

calculate_orbital_wavelength_variation is very broken #3

nabobalis opened this issue May 22, 2020 · 0 comments

Comments

@nabobalis
Copy link
Collaborator

calculate_orbital_wavelength_variation has the following problems (among others):

  • bad_aux is not used
  • slit_axis is not defined
  • gaussian1d_on_linear_bg is incorrectly called
  • raster is not defined.
  • date_created is not defined
  • abswvl_nuv is not used

Further:

  • It is too large, it needs to be split into smaller pieces.
  • No tests.
  • Needs to be checked with the IDL version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nabobalis