Insufficient STACK for tests on i386

[glondu]

In Debian, some tests fail on i386: https://buildd.debian.org/status/fetch.php?pkg=elpi&arch=i386&ver=1.16.10-2&stamp=1688713585&raw=0

The test sepcomp1 fails with Error: Thread.create: Resource temporarily unavailable.

This has been reported as Debian bug in: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1040541

All the tests pass when adding a zero to STACK. Maybe the value hardcoded in the Makefile should be revisited?

[gares]

Hi Stephane!

I'm about to make a release so I was checking which patch you were exactly using in Debian and I could not find it, I see one about TIMEOUT but nothing else.

Note that both TIMEOUT and STACK can be overridden via the command line, no need to patch.
Also, note that it is easy to disable demanding tests. From the opam file:

 [make "tests" "DUNE_OPTS=-p %{name}%" "SKIP=performance_HO" "SKIP+=performance_FO" "SKIP+=elpi_api_performance"] {with-test & os != "macos" & os-distribution != "alpine" & os-distribution != "freebsd"}

From what I can see all failing tests are in elpi_api_performance (but the next release may make these require less stack anyway for these tests...).

So, do you really need me to apply a parch upstream? If so, please reply today.

[glondu]

I was just suggesting to increase the default STACK value upstream. But indeed, this can be done at packaging level, without patching, and it is done this way in Debian:

https://salsa.debian.org/ocaml-team/elpi/-/blob/master/debian/rules#L15

This is ad-hoc, though, and I would prefer not having to do that.