Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing TryFrom implementations #17

Open
GnomedDev opened this issue Jan 1, 2024 · 0 comments · May be fixed by #19
Open

Missing TryFrom implementations #17

GnomedDev opened this issue Jan 1, 2024 · 0 comments · May be fixed by #19
Labels
enhancement New feature or request

Comments

@GnomedDev
Copy link

It seems like the nonmax types are missing TryFrom implementations from larger integer sizes, eg: TryFrom<u64> for NonMaxU32.
@GnomedDev GnomedDev mentioned this issue Jan 2, 2024
Merged
arqunis pushed a commit to serenity-rs/serenity that referenced this issue Jan 2, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
cf3d911 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 2, 2024
@GnomedDev @arqunis
Use nonmax::NonMax* types in Options wherever possible (serenity-…
cc3d6f0 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 5, 2024
@GnomedDev @arqunis
Use nonmax::NonMax* types in Options wherever possible (serenity-…
e1b1236 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
@LPGhatguy LPGhatguy added the enhancement New feature or request label Jan 6, 2024
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 16, 2024
@GnomedDev @arqunis
Use nonmax::NonMax* types in Options wherever possible (serenity-…
759d78a 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 22, 2024
@GnomedDev @arqunis
Use nonmax::NonMax* types in Options wherever possible (serenity-…
7d641d7 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Feb 9, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
e679003 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
arqunis pushed a commit to arqunis/serenity that referenced this issue Mar 1, 2024
@GnomedDev @arqunis
Use nonmax::NonMax* types in Options wherever possible (serenity-…
11b3c78 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 10, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
0cde496 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 11, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
8de7525 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 11, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
e1975a9 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Mar 13, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
82189e8 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 13, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
594945d 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Mar 19, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
5013d33 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Mar 19, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
db38311 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 21, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
38c16e8 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 25, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
1ca63b1 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 29, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
58823c2 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Mar 31, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
65c21dc 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Mar 31, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
671dc1b 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Apr 1, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
2801db0 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue May 14, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
9047793 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue May 14, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
431ac66 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue May 23, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
ac9e641 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue May 28, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
f677572 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Jun 9, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
4e6d123 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Jun 22, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
ffa1b01 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Jun 22, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
4eb7c1b 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this issue Jul 29, 2024
@GnomedDev @mkrasnitski
Use nonmax::NonMax* types in Options wherever possible (serenity-…
1363b95 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this issue Jul 30, 2024
@GnomedDev @mkrasnitski
Use nonmax::NonMax* types in Options wherever possible (serenity-…
0ba170c 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Aug 16, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
7c01a74 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
@RubixTheSlime RubixTheSlime linked a pull request Sep 1, 2024 that will close this issue
Open
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Oct 7, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
fabab1f 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to GnomedDev/serenity that referenced this issue Oct 20, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (serenity-…
7808dff 
…rs#2681)

This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [serenity-rs#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[serenity-rs#17]: LPGhatguy/nonmax#17
GnomedDev added a commit to serenity-rs/serenity that referenced this issue Oct 20, 2024
@GnomedDev
Use nonmax::NonMax* types in Options wherever possible (#2681)
d7e6688 
This swaps fields that store `Option<Int>` for `Option<NonMaxInt>` where the
maximum value would be ludicrous. Since `nonmax` uses `NonZero` internally,
this gives us niche optimisations, so model sizes can drop some more.

I have had to include a workaround for [#17] in `optional_string` by making my
own `TryFrom<u64>`, so that should be removable once that issue is fixed.

[#17]: LPGhatguy/nonmax#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add all possible int conversions RubixTheSlime/nonmax
2 participants
@LPGhatguy @GnomedDev