Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with CCL version #592

Closed
m-aguena opened this issue May 5, 2023 · 2 comments · Fixed by #595
Closed

Compatibility with CCL version #592

m-aguena opened this issue May 5, 2023 · 2 comments · Fixed by #595

Comments

@m-aguena
Copy link
Collaborator

m-aguena commented May 5, 2023

The latest CCL version has removed the _concentration_init function, so it breaks with the current CLMM implementation.
My suggestion is not only to update CLMM but also to have a failsafe (or at least a comment) for CCL versions that are compatible.
@hsinfan1996
Copy link
Collaborator

The latest dev version breaks, but v2.7.0 works.

@hsinfan1996
Copy link
Collaborator

hsinfan1996 commented May 5, 2023 •
edited
Loading

Before v2.7.0 (was v2.6.2 dev6), everything works, we don't even need UnlockInstance.
Between v2.7.1 dev1 to v2.7.1 dev9, need UnlockInstance before calling _concentration_init.
After v2.7.1 dev10, _concentration_init is removed from CCL and we enter the territory of v3 api.

@hsinfan1996 hsinfan1996 linked a pull request Jun 13, 2023 that will close this issue
Issue/592/ccl v3 #595
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/592/ccl v3 LSSTDESC/CLMM
2 participants
@m-aguena @hsinfan1996