-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with coordinate implementation #635
Comments
Hey @marina-ricci, just to be sure I understand what's the problem: Also I agree there should be a function to convert between them. Maybe Finally, there's the |
Hi @caioolivv ! I did not see that the examples/demo_coordinate_system_datasets.ipynb notebook was merged to main. I'm not sure it should stay here in it's current form. These are my suggestions :
I created a branch with a notebook to show the problem (it's not fully documented but should be understandable) |
We recently merged a PR to specify the coordinate system for the shear, but it lacks some functionalities.
First, it should be explained in details in a notebook, so that this bug would have been found. E.g : showing a profile taken with an incorrect coordinate system and showing all intermediate steps.
At the moment, the keyword is missing from
compute_tangential_and_cross_components
. You can pass it to theGalaxy Cluster
object, but it does not imply that it will be used (this should be avoided).Also, we might consider adding a simple way to convert between the two coordinate, once
compute_tangential_and_cross_components
is run (not having to rerun all steps).(Note : I discovered this while trying to implement in TXPipe and seeing no changes).
The text was updated successfully, but these errors were encountered: