Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/635/Modify coordinate system implementation #636

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

# CLMM
[![Build and Check](https://github.com/LSSTDESC/CLMM/workflows/Build%20and%20Check/badge.svg)](https://github.com/LSSTDESC/CLMM/actions?query=workflow%3A%22Build+and+Check%22)
[![Coverage Status](https://coveralls.io/repos/github/LSSTDESC/CLMM/badge.svg?branch=main)](https://coveralls.io/github/LSSTDESC/CLMM?branch=main)
Expand Down Expand Up @@ -110,6 +109,7 @@ the `CCL` publication be cited. See details
The `Cluster Toolkit` documentation can be found
[here](https://cluster-toolkit.readthedocs.io/en/latest/#).

The data for the notebook test_coordinate.ipynb is available at https://www.dropbox.com/scl/fo/dwsccslr5iwb7lnkf8jvx/AJkjgFeemUEHpHaZaHHqpAg?rlkey=efbtsr15mdrs3y6xsm7l48o0r&st=xb58ap0g&dl=0

# Contributing to CLMM <a name="contributing"></a>

Expand Down
1 change: 1 addition & 0 deletions docs/doc-config.ini
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@ OTHER
../examples/demo_compute_deltasigma_weights.ipynb
../examples/demo_mass_conversion.ipynb
../examples/demo_mock_ensemble_realistic.ipynb
../examples/demo_coordinate_system_datasets.ipynb
#../examples/other_compare_NFW_critical_massdef.ipynb
#../examples/other_flat_sky_limitations.ipynb
4 changes: 2 additions & 2 deletions examples/DC2/DC2_gt_profiles.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
Expand All @@ -614,7 +614,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.1"
"version": "3.9.0"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion examples/DC2/data_and_model_demo_DC2.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.1"
"version": "3.6.9"
}
},
"nbformat": 4,
Expand Down
34 changes: 2 additions & 32 deletions examples/demo_boost_factors.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"cells": [
{
"cell_type": "markdown",
"id": "b803f8e6",
"metadata": {},
"source": [
"# Boost factors"
Expand All @@ -11,7 +10,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "7180b199",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -26,7 +24,6 @@
},
{
"cell_type": "markdown",
"id": "11e76008",
"metadata": {},
"source": [
"Make sure we know which version we're using"
Expand All @@ -35,7 +32,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "389d5ab7",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -44,7 +40,6 @@
},
{
"cell_type": "markdown",
"id": "d86fa53c",
"metadata": {},
"source": [
"### Define cosmology object"
Expand All @@ -53,7 +48,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "74bcb35c",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -62,15 +56,13 @@
},
{
"cell_type": "markdown",
"id": "6b458081",
"metadata": {},
"source": [
"First, we want to generate a $\\Delta\\Sigma$ (excess surface density) profile from mock data, to which we can apply boost factors. The mock data is generated in the following cells."
]
},
{
"cell_type": "markdown",
"id": "de5340ee",
"metadata": {},
"source": [
"Generate cluster object from mock data"
Expand All @@ -79,7 +71,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "6cec7b64",
"metadata": {},
"outputs": [],
"source": [
Expand Down Expand Up @@ -107,7 +98,6 @@
},
{
"cell_type": "markdown",
"id": "50045a1f",
"metadata": {},
"source": [
"Loading this into a CLMM cluster object centered on (0,0)"
Expand All @@ -116,7 +106,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "a564b1c9",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -127,7 +116,6 @@
},
{
"cell_type": "markdown",
"id": "eb9c2218",
"metadata": {},
"source": [
"Compute cross and tangential excess surface density for each source galaxy"
Expand All @@ -136,7 +124,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "bc5b051d",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -154,7 +141,6 @@
},
{
"cell_type": "markdown",
"id": "26081451",
"metadata": {},
"source": [
"Calculate the binned profile"
Expand All @@ -163,7 +149,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "eaadac01",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -190,7 +175,6 @@
},
{
"cell_type": "markdown",
"id": "7e88afc4",
"metadata": {},
"source": [
"Plot the $\\Delta\\Sigma$ profile"
Expand All @@ -199,7 +183,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "0aeb2f52",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -219,15 +202,13 @@
},
{
"cell_type": "markdown",
"id": "e28ec4c5",
"metadata": {},
"source": [
"## Boost Factors"
]
},
{
"cell_type": "markdown",
"id": "19912d42",
"metadata": {},
"source": [
"CLMM offers two boost models, the NFW boost model, and a powerlaw boost model. \n",
Expand All @@ -242,7 +223,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "e6b6ee3d",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -255,7 +235,6 @@
},
{
"cell_type": "markdown",
"id": "58cbc299",
"metadata": {},
"source": [
"Plot the two boost factors, $B(R)$"
Expand All @@ -264,7 +243,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "1c1de291",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -278,7 +256,6 @@
},
{
"cell_type": "markdown",
"id": "30e8e6a0",
"metadata": {},
"source": [
"The $\\Delta\\Sigma$ profiles can be corrected with the boost factor using `correct_sigma_with_boost_values` or `correct_sigma_with_boost_model`. \n",
Expand All @@ -289,7 +266,6 @@
},
{
"cell_type": "markdown",
"id": "6c4daf84",
"metadata": {},
"source": [
"\n",
Expand All @@ -309,7 +285,6 @@
},
{
"cell_type": "markdown",
"id": "48e0f2ef",
"metadata": {},
"source": [
"First we will apply the boost factor with `correct_sigma_with_boost_values`"
Expand All @@ -318,7 +293,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "d7b5f71d",
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -332,7 +306,6 @@
},
{
"cell_type": "markdown",
"id": "15252880",
"metadata": {},
"source": [
"Plot the result"
Expand All @@ -341,7 +314,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "e2d90e0c",
"metadata": {},
"outputs": [],
"source": [
Expand Down Expand Up @@ -380,7 +352,6 @@
},
{
"cell_type": "markdown",
"id": "caf00c95",
"metadata": {},
"source": [
"Now the same again but with `correct_sigma_with_boost_model`"
Expand All @@ -389,7 +360,6 @@
{
"cell_type": "code",
"execution_count": null,
"id": "b4b3f953",
"metadata": {},
"outputs": [],
"source": [
Expand Down Expand Up @@ -440,7 +410,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"display_name": "Python 3",
"language": "python",
"name": "python3"
},
Expand All @@ -454,7 +424,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.8"
"version": "3.6.9"
}
},
"nbformat": 4,
Expand Down
Loading