Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixmod weight normalization bug #146

Open
aimalz opened this issue Jan 17, 2023 · 0 comments
Open

Mixmod weight normalization bug #146

aimalz opened this issue Jan 17, 2023 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers parameterization new/upgraded PDF parameterization need

Comments

@aimalz
Copy link
Collaborator

aimalz commented Jan 17, 2023

When using equal weights of 1 for each component as in the demo, the PPF ignores all components after the primary. We should enforce that weights be fractions summing to one to prevent this. These methods also require unit tests, and the mixmod_examples.ipynb demo should be edited to have an N an N-row ensemble of an M-component mixture model, with N =! M, as users currently can't see the intended arrangement of arguments from the N = M = 3 example.

@aimalz aimalz added the bug Something isn't working label Jan 17, 2023
@aimalz aimalz added the good first issue Good for newcomers label Jul 18, 2023
@aimalz aimalz added the parameterization new/upgraded PDF parameterization need label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers parameterization new/upgraded PDF parameterization need
Projects
None yet
Development

No branches or pull requests

2 participants