Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moment_partial from qp.Ensemble #219

Open
drewoldag opened this issue Mar 7, 2024 · 0 comments
Open

Remove moment_partial from qp.Ensemble #219

drewoldag opened this issue Mar 7, 2024 · 0 comments

Comments

@drewoldag
Copy link
Collaborator

In the qp.Ensemble class there is a method for calculating moments called moment_partial it doens't seem like it really belongs there since there aren't any other metric related methods in the Ensemble class. It also makes for a strange dependency graph. Additionally there are other ways to calculate the moments for an ensemble of PDFs. And finally, even in the demo notebooks, the moment_partial method is not shown.

I would advocate for removing it, however, I don't know if there are historical reasons for keeping it around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant