About item-info function

[vagrant-soul]

This is the same item in different languages
The item-info works fine in English.
in English, but in Chinese it gives an error :item not supported
I know this should be a problem with the item parsing, do I need the Chinese word list to work, which file is this part of the data in?
I tried to modify some parts of the file client.txt, but it fails
I'm using your dev branch.

物品種類: 弓
稀有度: 稀有
精魂 寶記
狂熱者之弓
--------
物理傷害: 31-47
閃電傷害: 4-89 (augmented)
暴擊率: 5.00%
每秒攻擊次數: 1.20
--------
需求:
等級: 39
敏捷: 90
--------
插槽: S S 
--------
物品等級: 43
--------
附加 2 至 40 閃電傷害 (rune)
--------
附加 2 至 49 閃電傷害
+14% 的暴擊傷害加成
每擊中一個敵人，獲得 3 生命
每個被擊殺的敵人，獲得 11 魔力

Item Class: Bows
Rarity: Rare
Spirit Mark
Zealot Bow
--------
Physical Damage: 31-47
Lightning Damage: 4-89 (augmented)
Critical Hit Chance: 5.00%
Attacks per Second: 1.20
--------
Requirements:
Level: 39
Dex: 90
--------
Sockets: S S 
--------
Item Level: 43
--------
Adds 2 to 40 Lightning Damage (rune)
--------
Adds 2 to 49 Lightning Damage
+14% to Critical Damage Bonus
Grants 3 Life per Enemy Hit
Gain 11 Mana per Enemy Killed

[Lailloken]

That's the issue I mentioned in the other thread. In PoE2, you can't copy the English item-name anymore by pressing ALT + CTRL + C.

The omni-key normally gets an item's full name, then checks a database of valid items to decide if the the item-info tooltip can be used (just to limit the use-cases and prevent it from completely breaking itself in edge-case scenarios), and I create that database based on PoB's databases with a separate script. I didn't want to create these by hand for PoE2, so the omni-key checks a list of item-classes instead (around 32 right now).

To save time (and because no-one was working on any translations), I didn't expose all these classes in the client.txt file, so it's hard-coded to use English ones for now. I also assumed the ALT + CTRL + C would be fixed by the time PoB2 came out, but that hasn't happened.

I guess I could expose them just in case the ALT copy stays broken for longer.

[Lailloken]

I have pushed another update for the client.txt language-file to the dev branch: 163e4e0

I hope this isn't getting too messy on your end, handling various files and branches.
This and other updates to the branch should now allow the use of wiki and poedb link via the context-menu, as well as the use of the item-info tooltip (some basic tests in German):

---

The wiki-link stays in English because that's the only language available on there (?).
The poedb-link uses the two values of the key system_poedb_lang in the client.txt language-file.

[Lailloken]

I had to push another update because ele-DPS wasn't working in the tooltip: 0a578c6 and ec38385

[vagrant-soul]

Okay, I'll keep trying when I have a little more time.

[vagrant-soul]

So far, most of the features have been tested successfully, except item-info and Map info panel (which I haven't tried yet).
Since I don't have a lot of time, I've done a very rough job, mainly to ensure that the basic functionality will not be affected.
I've uploaded a test version of the project,There are a lot of improper translations here and I need to slowly refine it
I've followed your instructions above and I've tried, but this is still unrecognizable and I need more time. If it's convenient, could you send me a reference file in German, I'd like to see what needs to be changed!

[Lailloken]

I don't have full files for German, just modified English ones with scattered modifications to test individual features: I think the item-info feature only needs the keys items_ilevel, items_requirements, items_rarity, items_class, and now of course all the items_class_XYZ

---

The item-checker.ahk on the dev-branch had an error that made it check the wrong key (items_classes_XYZ instead of items_class_XYZ: 509bf36

[Lailloken]

As a side note: I have merged the dev and main branches for a new release (v1.56.5), just to get some core changes out and to separate them from localization changes going forward.

[vagrant-soul]

The poe2db URL is incorrect, I've attached the correct one below

https://poe2db.tw/tw/Bows#ModifiersCalc

This one is wrong
https://poe2db.tw/zh-TW/Bows#ModifiersCalc

This version of item-info simple test passed, thanks, the next step I need to look into map-info, if it is convenient, please provide these related fields For example items_ilevel, items_requirements, items_rarity, items_class
thank you

[Lailloken]

When I refer to "keys" or "values", I usually mean those in the client.txt language-file (unless otherwise stated)
key = value

the first value in the image above is the language-code for the poedb-link, the second one is for the context-menu:

---

The other keys you mentioned have values that are required for parsing and for dividing the in-game item-text into blocks (I think you have already localized them correctly):

---

Btw, if you're using Discord, feel free to add me there (lailloken). I think I can answer more quickly there when it's about smaller things