-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What a coincidence #39
Comments
Hi @henfri
Above says no match data found. And interestingly
says 0 chunks (meaning file size is 0) Are you using new checksum types ? can you share some details on your BTRFS setup? |
My initial impression : you are running into some dduper bug! |
Hello,
Hm, I have deleted the zip file now, to check if now another file would take its place... But I found another case now:
No, no new checksum types. I have installed the static binary as per your instructions.
Regards, |
Thanks for the details. Couple of things will be helpful:
|
Hello,
How it was created: Sorry, that is too long ago. I think it was a single FS first and then I changed it to RAID1 after adding a second drive.
Greetings, |
Thanks for the details. Strangely the basic check fails for 50MB files.
It should report at-least 3 chunks. (since we have chunk size as 16MB). I did a quick check with RAID1 and it produced expected results.
May be this causes trouble, I'll start single FS and convert it into RAID1 and verify the results. |
Hello, that's really odd. Please let me know if I can do more to help you finding the issue. Regards, |
sure, let me check few stuffs to re-create your issue.
No, I don't think there is any data loss from your run. Since dduper always show |
Hi @henfri , Can you provide extent details output for these files?
|
Wait, are you running dduper on btrfs subvolume. Can you try it on root volume ? May be this issue related to #35 (comment) |
Hello, it is a sub-volume, but it is not mounted as sub-volume.
I ran it in the root folder of it now. That does not look good:
I am currently running a balance.. Not sure if that could be related.
|
thanks,
Okay, let me know the status of We have two other bugs related to sub-volume. which shows '0' chunks. I hope to fix them soon. |
Quick update on subvolume: I spent 3 or 4 days trying to figure out issue with sub-volume, I can dump csum of subvolume from different code path. Still need some work to explore the btrfs disk-layout. |
Ok, thanks for the status update and sorry for my late reply. Here the output after the balance (the balance did not fix the transid failures, but this did:
Regards, |
thanks for the output.
Now it seems like reporting correct values. Can you try running dedupe on two files
After dedupe, can you see values under |
Hm...
I have no Idea, why I have the I do not see any Regards, |
Typically points to file system errors. and you can see dduper fails to open the device and it said
So it didn't perform any deduplication on your device. If I'm not wrong, something going/gone with your filesystem. please post the errors on btrfs emailing list and resolve the issue before running dduper. Similar issue: https://stackoverflow.com/a/46472522/246365 |
Hello, I did post the error on the btrfs mailing list and it is suspected to be a bug in dduper:
I suggest to continue (if needed) the discussion on the btrfs mailing-list. Regards, |
@henfri , First of all, sorry for pretty late response. Thanks for updating the issue. I had a quick look at the mailing list thread. I agree that it looks like a bug with dduper. I'll try to reproduce this issue and hope to fix it. Thank you again! |
should i be worried? |
i think, if the dry-run indicate no errors, i shouldn't worry about deduping my btrfs partition? |
In this issue, @henfri received messages like #39 (comment)
As per ML post, this seems to happen when file system is currently active and file are being updated.
Yes, With If you plan to run it on critical data, I would recommend:
Please remember dduper works only with top-level subvolume (id=5) and other subvolume with id >= 256 won't work, as of now. |
wow thanks for the very fast reply |
does the partition have to be unmounted? or that doesn't matter? if |
I haven't tried using dduper after running duperremove. But I guess it won't make any difference for dduper as it relies on low-level csum data. To be 100% sure, can you try running it on sample directory a) first run duperremove and then check with dduper. Verify the results.
Currently dduper expects partition to be mounted. That's good idea, to unmount partition and then run dedupe on it. This should resolve ML reported issues. Let me try to add new option |
As mentioned in the mailing list, are you considering switching to using the TREE_SEARCH_V2 ioctl?
Thanks, |
Hi @RlndVt , Yes, I'm planning to add "TREE_SEARCH_V2 ioctl" as option. Initially, user can pass cli option (--use-ioctl) to use it, later completely switch to ioctl. I'm kind of stuck with fixing dduper on |
Hello,
thanks for dduper!
I have run over a directory recursively:
What I find odd is, that the plugin.video.vdr.recordings_0.2.4.zip seems to match every single ts file (https://fileinfo.com/extension/ts).
I can imagine that every ts file must contain a certain bit-pattern in it... But that to be in a zip file as well?
Greetings,
Hendrik
The text was updated successfully, but these errors were encountered: