Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs from testing RO-Crate creation #125

Closed
4 tasks done
rosanna-smith opened this issue May 9, 2024 · 8 comments
Closed
4 tasks done

Bugs from testing RO-Crate creation #125

rosanna-smith opened this issue May 9, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@rosanna-smith
Copy link
Contributor

rosanna-smith commented May 9, 2024

These are some of the bugs/questions River, Otis and I ran into creating an RO-Crate for the Deafblind corpus (using the mode Language Data Commons top level Collection (corpus):

  • @id defaults to ./ - is this something that needs to be edited (add DOI here?) or should that remain as is? Not clear currently.
  • Collection Description help text says max 200 word limit, though our description exceeded this and still saved, so assume this is more guidance than a set rule?
  • The red property required information icons look more like errors, so even when we'd filled these sections, it seems like there's a problem when there's not. Another colour might be better.
  • When creating people, e.g. authors etc. should the ORCID be included in the description or is there another section for this?
@r-tae
Copy link

r-tae commented May 9, 2024

Also there's a field 'Citation', the description is "Associated publications". I have a list of publications that reference the corpus, is this the proper place for that?

Never mind, Rosanna sent me documentation about it on Slack

@r-tae
Copy link

r-tae commented May 9, 2024

Re: the organisation lookup

I checked on my local version (up-to-date with main), there is debouncing its just the lookup can take up to 15s, which means just debouncing isn't enough.

You can see in my example that the middle request resolves last and I end up with no monash results.
CleanShot 2024-05-09 at 11 15 44

It would be fixable if we could cancel in-flight requests, but I don't understand the code well enough to do that (and promises aren't cancellable by themselves so it isn't a particularly quick change)

@moisbo moisbo assigned rosanna-smith and unassigned ptsefton, alvinsw and moisbo May 15, 2024
@moisbo moisbo added this to the Critical Bug Fix milestone May 15, 2024
@moisbo moisbo added the bug Something isn't working label May 16, 2024
@rosanna-smith
Copy link
Contributor Author

Question about this section @ptsefton: When creating people, e.g. authors etc. should the ORCID be included in the description or is there another section for this?

I checked the language data commons top level and for author we have @id, @type, Name and Description. Should the ORCID go in the description field or in @id? The tooltip for @id just says Uniquie ID, but it's not one of the tooltips I can edit in the mode.

@ptsefton
Copy link
Contributor

ptsefton commented May 16, 2024 via email

@ptsefton
Copy link
Contributor

ptsefton commented May 16, 2024 via email

@ptsefton
Copy link
Contributor

ptsefton commented May 16, 2024 via email

@r-tae
Copy link

r-tae commented May 16, 2024

Perfect, thanks @ptsefton ! I believe I have enough to finalise both the Australian Deafblind Signing and Auslan Corpora

@rosanna-smith
Copy link
Contributor Author

Marking as closed since @alvinsw will be updating the description of the @id in Crate-O. (thanks!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants