New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FloatTag and DoubleTag do not consider NaN values in equality check #1

Open

Marcono1234 opened this issue Jan 3, 2019 · 0 comments

Assignees

Labels

bug

Marcono1234 commented Jan 3, 2019

LanternNBT/nbt/src/main/java/org/lanternpowered/nbt/FloatTag.java

Line 92 in db0a79e

return obj instanceof FloatTag && ((FloatTag) obj).value == this.value;

LanternNBT/nbt/src/main/java/org/lanternpowered/nbt/DoubleTag.java

Line 92 in db0a79e

return obj instanceof DoubleTag && ((DoubleTag) obj).value == this.value;

See KyoriPowered/nbt#1 for a suggested fix

Cybermaxke self-assigned this

Cybermaxke added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment